Skip to content

[code-infra] Allow postinstall scripts for packages requesting it #17635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Apr 30, 2025

Fix the following warning

Before

Screenshot 2025-04-30 at 15 10 54

After

Screenshot 2025-04-30 at 15 14 38

@LukasTy LukasTy added type: enhancement This is not a bug, nor a new feature scope: code-infra labels Apr 30, 2025
@LukasTy LukasTy self-assigned this Apr 30, 2025
@mui-bot
Copy link

mui-bot commented Apr 30, 2025

Deploy preview: https://deploy-preview-17635--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against bfe0648

@LukasTy LukasTy marked this pull request as ready for review April 30, 2025 12:27
@LukasTy LukasTy requested a review from a team April 30, 2025 12:27
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering what would be the correct approach here, but since these scripts used to run without restrictions in pnpm < 10, I chose to let them do so as well.

@Janpot
Copy link
Member

Janpot commented May 1, 2025

I was wondering what would be the correct approach here

Every script that runs on postinstall is a potential supply chain attack. Personally, I think I'm in favour of a whitelisting approach, but no strong opinion.

@LukasTy LukasTy merged commit b0bf512 into mui:master May 1, 2025
25 checks passed
@LukasTy LukasTy deleted the fix-after-dep-install-warning branch May 1, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants