Skip to content

[DataGrid] Refactor: Use arguments selector for checkbox props #17683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 9, 2025
Merged

[DataGrid] Refactor: Use arguments selector for checkbox props #17683

merged 5 commits into from
May 9, 2025

Conversation

MBilalShafi
Copy link
Member

Changes

  • Use selector with arguments for checkbox props
  • Refactor the internal logic to be more readable and consistent with the TreeView logic

@MBilalShafi MBilalShafi added scope: data grid Changes or issues related to the data grid product feature: Selection Related to the data grid Selection feature type: enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be auto-cherry-picked to a version branch after merge—add a version label as target v7.x labels May 5, 2025
@mui-bot
Copy link

mui-bot commented May 5, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-17683--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 11ecd2e

@MBilalShafi MBilalShafi marked this pull request as ready for review May 7, 2025 20:31
@MBilalShafi MBilalShafi requested a review from a team May 7, 2025 20:31
@MBilalShafi MBilalShafi enabled auto-merge (squash) May 9, 2025 11:18
@MBilalShafi MBilalShafi merged commit 97cc309 into mui:master May 9, 2025
21 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2025

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request May 9, 2025
@MBilalShafi @web-flow
[DataGrid] Refactor: Use arguments selector for checkbox props (#17683)
115bc72
@github-actions github-actions bot mentioned this pull request May 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminmeh arminmeh arminmeh approved these changes

Assignees
No one assigned
Labels
feature: Selection Related to the data grid Selection feature needs cherry-pick The PR should be auto-cherry-picked to a version branch after merge—add a version label as target scope: data grid Changes or issues related to the data grid product type: enhancement This is not a bug, nor a new feature v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MBilalShafi @mui-bot @arminmeh