[DataGrid] Fix cell editing of computed columns with data source #17684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if there is a column which does not have a respective property in row data and using
dataSource
and cell editing,dataSource.editRow
does not fire. This can happen with computed columns, for example.This is due to the code checking if the
row[field]
has changed. In this case it would be always undefined and theupdateStateToStopCellEditMode
would return early without callingdataSource.editRow
.useGridRowEditing
usesisDeepEqual
instead to check if something in the row has been changed. I thought it might be reasonable to use it inuseGridCellEditing
as well. Perhaps it wouldn't even be necessary to do that checking, but I will leave that decision to you.Here is a sandbox inspired by the following demo: https://mui.com/x/react-data-grid/editing/#value-parser-and-value-setter
https://stackblitz.com/edit/tswwgcr5-5zr3q5b1?file=src%2FDemo.tsx
Editing the
Computed
column causes no updates to the grid nor it fires thedataSource.updateRow
.Here is the same sandbox with this PR's changes:
https://stackblitz.com/edit/uouznmzp?file=src%2FDemo.tsx