[pickers] Avoid DigitalClock stealing focus from a Picker open button on close
#17686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
type: bug
|
Deploy preview: https://deploy-preview-17686--material-ui-x.netlify.app/ |
flaviendelangle
approved these changes
May 5, 2025
JCQuintas
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address this: https://github.com/mui/mui-x/pull/14508/files#diff-d34f269f8eebce25782ac5211d76a046669733a73ba6a56ca97685c310f6ed01R194
Currently, the focus is not returned to the Picker open button on
MobileTimeRangePicker.The reason for this issue is the fact that
DigitalClockandMultiSectionDigitalClock"steals" the focus from the Dialog behavior too early.Changing the effect to a
layoutEffectavoids this problem.P.S. I couldn't reproduce this problem even on e2e tests. 🙈
So, kudos to
vitestas only it could reliably fail here...Also address this "brain-fart": #17517 (comment)