[DataGrid] Fix column spanning jump on scroll #17759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
type: bug
|
Deploy preview: https://deploy-preview-17759--material-ui-x.netlify.app/ |
cherniavskii
added
needs cherry-pick
arminmeh
reviewed
May 9, 2025
| let foundStableColumn = false; | ||
|
|
||
| // Keep checking columns until we find one that's not spanned in any visible row | ||
| while (!foundStableColumn && firstNonSpannedColumnToRender >= 0) { |
There was a problem hiding this comment.
IIUC firstNonSpannedColumnToRender is always >= 0
| firstNonSpannedColumnToRender, | ||
| ); | ||
|
|
||
| if ( |
There was a problem hiding this comment.
at certain scroll positions it seems that this code is called in intervals (don't think it is because of the changes made in this PR)
Screen.Recording.2025-05-09.at.14.42.59.mov
There was a problem hiding this comment.
Nice catch! Opened a separate PR for this one: #17779
MBilalShafi
approved these changes
May 9, 2025
|
Cherry-pick PRs will be created targeting branches: v7.x |
JCQuintas
pushed a commit
to JCQuintas/mui-x
that referenced
this pull request
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14130
Before: https://stackblitz.com/edit/vaghyrmw
After: https://stackblitz.com/edit/vaghyrmw-a2jg1urg