-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[docs] Add "upgrade to v8" callout on v7 planned pages #17901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview: https://deploy-preview-17901--material-ui-x.netlify.app/ Updated pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement. 👍
WDYT, would it make sense to change the menu items to be shown as new
instead of planned
at the same time? 🤔
|
||
Don't hesitate to leave a comment on the same issue to influence what gets built. Especially if you already have a use case for this component, or if you are facing a pain point with your current solution. | ||
:::success | ||
Pivoting is available in MUI X v8+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about linking to the feature on v8 as well? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. As a general rule I'm hesitant to add more than one link—ideally there should be only one action for the user to take after reading, or else we risk sending people in too many different directions. With that in mind, I would much prefer to direct them to upgrade instead of reading a doc for a feature they can't use (yet). All that said, if others would like see the features linked then I'm ok with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong preference here.
If you think that it hinders UX, I'm fine and agree that the main actionable item is the upgrade guide. 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I'll leave it as is then, and we can always come back and add the links later if it seems like users need them.
I debated updating these messages but ultimately decided not to. Where do we draw the line with maintenance of past docs versions? After updating from "planned" to "new" now, would we come back to the v7 docs after v9 to remove all of the "new" chips altogether? In the interest of keeping maintenance needs to a minimum, I'd err on the side of leaving most things in the v7 docs untouched from here on out, except where it's trivially simple to cherry-pick v8 changes. |
(I reverted the title back to remove |
Fair points. 👌 |
Updates the copy on "planned" pages in the v7 docs to instruct users to upgrade to v8 to use the features.
Preview: https://deploy-preview-17901--material-ui-x.netlify.app/x/react-data-grid/pivoting/