Skip to content

[charts-pro] Update zoom slider range selection cursor #17977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented May 23, 2025

Use pointer instead of crosshair, as suggested by @KenanYusuf.

Screen.Recording.2025-05-23.at.12.01.33.mov

Copy link

github-actions bot commented May 23, 2025

Thanks for adding a type label to the PR! 👍

@bernardobelchior bernardobelchior added type: enhancement This is not a bug, nor a new feature scope: charts Changes or issues related to the charts product labels May 23, 2025
@mui-bot
Copy link

mui-bot commented May 23, 2025

Deploy preview: https://deploy-preview-17977--material-ui-x.netlify.app/

Bundle size report

Total Size Change:${\tiny{\color{green}▼}}$-6.16KB(-0.05%) - Total Gzip Change:${\tiny{\color{green}▼}}$-2.19KB(-0.06%)
Files: 118 total (0 added, 0 removed, 44 changed)

@mui/x-charts-pro/ChartZoomSliderparsed:${\tiny{\color{red}▲}}$+339B(+0.51%) gzip:${\tiny{\color{red}▲}}$+100B(+0.43%)
@mui/x-charts-pro/ChartContainerProparsed:${\tiny{\color{green}▼}}$-1.15KB(-0.81%) gzip:${\tiny{\color{green}▼}}$-422B(-0.88%)
@mui/x-charts-pro/ChartDataProviderProparsed:${\tiny{\color{green}▼}}$-1.09KB(-0.81%) gzip:${\tiny{\color{green}▼}}$-416B(-0.92%)
@mui/x-charts-pro/FunnelChartparsed:${\tiny{\color{green}▼}}$-1.06KB(-0.52%) gzip:${\tiny{\color{green}▼}}$-423B(-0.64%)
@mui/x-charts-pro/Heatmapparsed:${\tiny{\color{green}▼}}$-996B(-0.54%) gzip:${\tiny{\color{green}▼}}$-382B(-0.63%)
@mui/x-chartsparsed:${\tiny{\color{green}▼}}$-738B(-0.28%) gzip:${\tiny{\color{green}▼}}$-186B(-0.23%)
@mui/x-charts/PieChartparsed:${\tiny{\color{green}▼}}$-582B(-0.36%) gzip:${\tiny{\color{green}▼}}$-201B(-0.38%)
@mui/x-charts/ScatterChartparsed:${\tiny{\color{green}▼}}$-508B(-0.32%) gzip:${\tiny{\color{green}▼}}$-142B(-0.27%)
@mui/x-charts/LineChartparsed:${\tiny{\color{green}▼}}$-489B(-0.26%) gzip:${\tiny{\color{green}▼}}$-110B(-0.18%)
@mui/x-charts/BarChartparsed:${\tiny{\color{green}▼}}$-488B(-0.28%) gzip:${\tiny{\color{green}▼}}$-144B(-0.25%)

Show 34 more bundle changes

@mui/x-data-grid-pro/DataGridProparsed:${\tiny{\color{red}▲}}$+115B(+0.03%) gzip:${\tiny{\color{red}▲}}$+45B(+0.04%)
@mui/x-data-grid-premiumparsed:${\tiny{\color{red}▲}}$+111B(+0.02%) gzip:${\tiny{\color{red}▲}}$+42B(+0.03%)
@mui/x-data-grid-proparsed:${\tiny{\color{red}▲}}$+111B(+0.02%) gzip:${\tiny{\color{red}▲}}$+18B(+0.01%)
@mui/x-date-pickers-proparsed:${\tiny{\color{red}▲}}$+111B(+0.04%) gzip:${\tiny{\color{red}▲}}$+44B(+0.05%)
@mui/x-date-pickers-pro/DateRangePickerparsed:${\tiny{\color{red}▲}}$+111B(+0.06%) gzip:${\tiny{\color{red}▲}}$+36B(+0.07%)
@mui/x-date-pickers-pro/DateTimeRangePickerparsed:${\tiny{\color{red}▲}}$+111B(+0.05%) gzip:${\tiny{\color{red}▲}}$+47B(+0.08%)
@mui/x-date-pickers-pro/DesktopDateRangePickerparsed:${\tiny{\color{red}▲}}$+111B(+0.07%) gzip:${\tiny{\color{red}▲}}$+43B(+0.08%)
@mui/x-date-pickers-pro/DesktopDateTimeRangePickerparsed:${\tiny{\color{red}▲}}$+111B(+0.06%) gzip:${\tiny{\color{red}▲}}$+37B(+0.06%)
@mui/x-date-pickers-pro/DesktopTimeRangePickerparsed:${\tiny{\color{red}▲}}$+111B(+0.08%) gzip:${\tiny{\color{red}▲}}$+34B(+0.08%)
@mui/x-date-pickers-pro/MobileDateRangePickerparsed:${\tiny{\color{red}▲}}$+111B(+0.07%) gzip:${\tiny{\color{red}▲}}$+34B(+0.07%)
@mui/x-date-pickers-pro/MobileDateTimeRangePickerparsed:${\tiny{\color{red}▲}}$+111B(+0.06%) gzip:${\tiny{\color{red}▲}}$+37B(+0.06%)
@mui/x-date-pickers-pro/MobileTimeRangePickerparsed:${\tiny{\color{red}▲}}$+111B(+0.08%) gzip:${\tiny{\color{red}▲}}$+30B(+0.07%)
@mui/x-date-pickers-pro/StaticDateRangePickerparsed:${\tiny{\color{red}▲}}$+111B(+0.11%) gzip:${\tiny{\color{red}▲}}$+36B(+0.12%)
@mui/x-date-pickers-pro/TimeRangePickerparsed:${\tiny{\color{red}▲}}$+111B(+0.08%) gzip:${\tiny{\color{red}▲}}$+34B(+0.08%)
@mui/x-tree-view-proparsed:${\tiny{\color{red}▲}}$+111B(+0.14%) gzip:${\tiny{\color{red}▲}}$+32B(+0.13%)
@mui/x-data-grid-premium/DataGridPremiumparsed:${\tiny{\color{red}▲}}$+110B(+0.02%) gzip:${\tiny{\color{red}▲}}$+47B(+0.03%)
@mui/x-tree-view-pro/RichTreeViewProparsed:${\tiny{\color{red}▲}}$+110B(+0.15%) gzip:${\tiny{\color{red}▲}}$+27B(+0.12%)
@mui/x-date-pickers-pro/DateRangeCalendarparsed:${\tiny{\color{red}▲}}$+109B(+0.14%) gzip:${\tiny{\color{red}▲}}$+34B(+0.14%)
@mui/x-date-pickers-pro/DateRangePickerDayparsed:${\tiny{\color{red}▲}}$+109B(+0.44%) gzip:${\tiny{\color{red}▲}}$+30B(+0.38%)
@mui/x-charts/ChartsAxisparsed:${\tiny{\color{red}▲}}$+95B(+0.14%) gzip:${\tiny{\color{red}▲}}$+19B(+0.08%)
@mui/x-charts/ChartsXAxisparsed:${\tiny{\color{red}▲}}$+95B(+0.14%) gzip:${\tiny{\color{red}▲}}$+14B(+0.06%)
@mui/x-charts/ChartsYAxisparsed:${\tiny{\color{red}▲}}$+95B(+0.14%) gzip:${\tiny{\color{red}▲}}$+15B(+0.06%)
@mui/x-charts/ChartsReferenceLineparsed:${\tiny{\color{red}▲}}$+92B(+0.15%) gzip:${\tiny{\color{red}▲}}$+26B(+0.12%)
@mui/x-charts/Gaugeparsed:${\tiny{\color{red}▲}}$+92B(+0.09%) gzip:${\tiny{\color{red}▲}}$+18B(+0.05%)
@mui/x-charts/ChartsTextparsed:${\tiny{\color{red}▲}}$+89B(+3.01%) gzip:${\tiny{\color{red}▲}}$+19B(+1.28%)
@mui/x-charts-pro/BarChartProparsed:${\tiny{\color{red}▲}}$+50B(+0.02%) gzip:${\tiny{\color{red}▲}}$+21B(+0.03%)
@mui/x-charts-pro/LineChartProparsed:${\tiny{\color{red}▲}}$+50B(+0.02%) gzip:${\tiny{\color{red}▲}}$+18B(+0.02%)
@mui/x-charts-pro/ScatterChartProparsed:${\tiny{\color{red}▲}}$+30B(+0.02%) gzip:${\tiny{\color{red}▲}}$+36B(+0.06%)
@mui/x-charts-proparsed:${\tiny{\color{green}▼}}$-470B(-0.14%) gzip:${\tiny{\color{green}▼}}$-120B(-0.12%)
@mui/x-charts/ChartContainerparsed:${\tiny{\color{green}▼}}$-457B(-0.41%) gzip:${\tiny{\color{green}▼}}$-149B(-0.39%)
@mui/x-charts/RadarChartparsed:${\tiny{\color{green}▼}}$-428B(-0.27%) gzip:${\tiny{\color{green}▼}}$-173B(-0.34%)
@mui/x-charts/SparkLineChartparsed:${\tiny{\color{green}▼}}$-419B(-0.24%) gzip:${\tiny{\color{green}▼}}$-144B(-0.25%)
@mui/x-charts/ChartDataProviderparsed:${\tiny{\color{green}▼}}$-417B(-0.39%) gzip:${\tiny{\color{green}▼}}$-151B(-0.42%)
@mui/x-data-gridparsed: 0B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 14508c7

Copy link
Member

@KenanYusuf KenanYusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use pointer for hovering on the track, and then when you are creating the new selection, it switches to the resize cursor?

Copy link

codspeed-hq bot commented May 23, 2025

CodSpeed Performance Report

Merging #17977 will not alter performance

Comparing bernardobelchior:improv-zoom-slider-range-selection (14508c7) with master (ea53ddc)

Summary

✅ 9 untouched benchmarks

@bernardobelchior
Copy link
Member Author

Would it be possible to use pointer for hovering on the track, and then when you are creating the new selection, it switches to the resize cursor?

Something like this?

Screen.Recording.2025-05-23.at.12.01.33.mov

@KenanYusuf
Copy link
Member

Something like this?

@bernardobelchior yeah, that would be an improvement I think.

Comment on lines 30 to 36
const Group = styled('g')({
[`&.${chartAxisZoomSliderClasses.root}.${chartAxisZoomSliderClasses.horizontal} .${chartAxisZoomSliderClasses.track}.${chartAxisZoomSliderClasses.selecting}`]:
{ cursor: 'ew-resize' },
[`&.${chartAxisZoomSliderClasses.root}.${chartAxisZoomSliderClasses.vertical} .${chartAxisZoomSliderClasses.track}.${chartAxisZoomSliderClasses.selecting}`]:
{ cursor: 'ns-resize' },
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bit weird to have that many classes. Users would need a specificity higher than 0-5-0 to verride those rules.

What about moving that style into the ZoomSliderTrack?

You can look at this component. In short, you pass the props of interest (the direction and the selecting state) such that it adapts its style to it, but do not propagate those props. The goal is to have only one class such that any style override wins over the default one

https://github.com/mui/mui-x/blob/master/packages/x-date-pickers/src/internals/components/PickersToolbar.tsx/#L51-L82

Copy link
Member Author

@bernardobelchior bernardobelchior May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the code as suggested. Is that what you had in mind?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go further on the simplification with

const ZoomSliderTrack = styled('rect', {
  shouldForwardProp: (prop) =>
    shouldForwardProp(prop) && prop !== 'axisDirection' && prop !== 'isSelecting',
})<{ axisDirection: 'x' | 'y'; isSelecting: boolean }>(({ theme }) => ({
  fill:
    theme.palette.mode === 'dark'
      ? (theme.vars || theme).palette.grey[800]
      : (theme.vars || theme).palette.grey[300],
  cursor: 'pointer',
  variants: [
    {
      props: { axisDirection: 'y', isSelecting: true },
      style: {
        cursor: 'ns-resize',
      },
    },
    {
      props: { axisDirection: 'x', isSelecting: true },
      style: {
        cursor: 'ew-resize',
      },
    },
  ],
}));

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to work 😄 done 👍

@bernardobelchior bernardobelchior force-pushed the improv-zoom-slider-range-selection branch from 02ff199 to f77dbd3 Compare May 26, 2025 10:54
@bernardobelchior bernardobelchior merged commit 9eea491 into mui:master May 26, 2025
24 checks passed
@bernardobelchior bernardobelchior deleted the improv-zoom-slider-range-selection branch May 26, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: charts Changes or issues related to the charts product type: enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants