Skip to content

[charts-pro] Split ChartAxisZoomSlider into smaller files #18011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bernardobelchior
Copy link
Member

Part of #15383.

Follow-up to this comment.

Copy link

github-actions bot commented May 26, 2025

Thanks for adding a type label to the PR! 👍

@bernardobelchior bernardobelchior added type: enhancement This is not a bug, nor a new feature scope: charts Changes or issues related to the charts product labels May 26, 2025
@mui-bot
Copy link

mui-bot commented May 26, 2025

Deploy preview: https://deploy-preview-18011--material-ui-x.netlify.app/

Bundle size report

Total Size Change:${\tiny{\color{red}▲}}$+56B(0.00%) - Total Gzip Change:${\tiny{\color{red}▲}}$+104B(0.00%)
Files: 118 total (0 added, 0 removed, 5 changed)

Show 5 more bundle changes

@mui/x-charts-pro/BarChartProparsed:${\tiny{\color{red}▲}}$+14B(+0.01%) gzip:${\tiny{\color{red}▲}}$+19B(+0.03%)
@mui/x-charts-pro/LineChartProparsed:${\tiny{\color{red}▲}}$+14B(+0.01%) gzip:${\tiny{\color{red}▲}}$+5B(+0.01%)
@mui/x-charts-pro/ScatterChartProparsed:${\tiny{\color{red}▲}}$+14B(+0.01%) gzip:${\tiny{\color{red}▲}}$+73B(+0.11%)
@mui/x-charts-pro/ChartZoomSliderparsed:${\tiny{\color{red}▲}}$+8B(+0.01%) gzip:${\tiny{\color{red}▲}}$+13B(+0.06%)
@mui/x-charts-proparsed:${\tiny{\color{red}▲}}$+6B(0.00%) gzip:${\tiny{\color{green}▼}}$-6B(-0.01%)

Details of bundle changes

Generated by 🚫 dangerJS against 16111df

@bernardobelchior bernardobelchior force-pushed the reorganize-chart-zoom-slider-files branch from fedccbc to 16111df Compare May 26, 2025 14:29
Copy link

codspeed-hq bot commented May 26, 2025

CodSpeed Performance Report

Merging #18011 will not alter performance

Comparing bernardobelchior:reorganize-chart-zoom-slider-files (16111df) with master (9eea491)

Summary

✅ 9 untouched benchmarks

@bernardobelchior bernardobelchior marked this pull request as ready for review May 26, 2025 15:25
@bernardobelchior bernardobelchior merged commit 2cefa1e into mui:master May 26, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: charts Changes or issues related to the charts product type: enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants