-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[infra] Improve test setup #18228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Improve test setup #18228
Conversation
Deploy preview: https://deploy-preview-18228--material-ui-x.netlify.app/ Bundle size reportTotal Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%) |
orchestratorScripts: [ | ||
{ | ||
id: 'vitest-reload-on-error', | ||
content: `window.addEventListener('vite:preloadError', (event) => { window.location.reload(); });`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect these issues are due to OOM/Process/crash of the server. I've created https://github.com/mui/mui-x/pull/18230/files to try to alleviate the problem by using a single browser server to run all tests, rather than the current approach which creates an instance for every package. In the errors you linked, you see this at the start Which makes it at least somewhat clear that the server died, and the failure to find the Which can be seen more towards the end, and it mentions it didn't find it on the server (localhost:xxxx) |
Attempt to address flaky failures like:
It looks like the setup refactor might have reduced the runtime of browser tests.
Not saying that these will fix flaky tests, but in any case, I don't see why they couldn't be merged as general improvements. 🤔