Skip to content

[infra] Improve test setup #18228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jun 4, 2025

@LukasTy LukasTy self-assigned this Jun 4, 2025
@LukasTy LukasTy added test type: enhancement This is not a bug, nor a new feature scope: code-infra Specific to the code-infra product labels Jun 4, 2025
@mui-bot
Copy link

mui-bot commented Jun 4, 2025

Deploy preview: https://deploy-preview-18228--material-ui-x.netlify.app/

Bundle size report

Total Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%)
Files: 120 total (0 added, 0 removed, 0 changed)

Details of bundle changes

Generated by 🚫 dangerJS against 4465504

@LukasTy LukasTy changed the title Test an even listener reloading page on error [infra] Improve test setup Jun 4, 2025
orchestratorScripts: [
{
id: 'vitest-reload-on-error',
content: `window.addEventListener('vite:preloadError', (event) => { window.location.reload(); });`,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasTy LukasTy marked this pull request as ready for review June 4, 2025 15:03
@LukasTy LukasTy requested review from JCQuintas and a team June 4, 2025 15:03
@JCQuintas
Copy link
Member

I suspect these issues are due to OOM/Process/crash of the server. I've created https://github.com/mui/mui-x/pull/18230/files to try to alleviate the problem by using a single browser server to run all tests, rather than the current approach which creates an instance for every package.

In the errors you linked, you see this at the start
Screenshot 2025-06-04 at 17 54 45

Which makes it at least somewhat clear that the server died, and the failure to find the setupVitest file is due to the server not answering vitest.

Which can be seen more towards the end, and it mentions it didn't find it on the server (localhost:xxxx)
Screenshot 2025-06-04 at 17 55 57

@LukasTy LukasTy merged commit c677b1d into mui:master Jun 5, 2025
22 checks passed
@LukasTy LukasTy deleted the try-a-browser-tests-fix branch June 5, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the code-infra product test type: enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants