Skip to content

[DataGrid] Fix registerPipeProcessor() for Node v20 #18241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

[DataGrid] Fix registerPipeProcessor() for Node v20 #18241

merged 1 commit into from
Jun 5, 2025

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Jun 5, 2025

Fixes regression added by #17558
On Node v20, filter does not exist on MapIterator

@arminmeh arminmeh requested a review from a team June 5, 2025 09:36
@arminmeh arminmeh added scope: data grid Changes or issues related to the data grid product type: regression A bug that reintroduces previously resolved issues or breaks existing functionality. feature: State management Related to the data grid State management feature labels Jun 5, 2025
@mui-bot
Copy link

mui-bot commented Jun 5, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-18241--material-ui-x.netlify.app/

Bundle size report

Total Size Change: 0B(0.00%) - Total Gzip Change:${\tiny{\color{green}▼}}$-7B(0.00%)
Files: 120 total (0 added, 0 removed, 5 changed)

Show 5 more bundle changes

@mui/x-data-grid parsed: 0B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-data-grid-premium parsed: 0B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%)
@mui/x-data-grid-premium/DataGridPremium parsed: 0B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-data-grid-pro parsed: 0B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%)
@mui/x-data-grid-pro/DataGridPro parsed: 0B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against da707c1

@arminmeh
Copy link
Contributor Author

arminmeh commented Jun 5, 2025

deploy passed on retry
https://app.netlify.com/projects/material-ui-x/deploys/684173a92d11a943e3ae0ef8

@arminmeh arminmeh enabled auto-merge (squash) June 5, 2025 10:48
@arminmeh arminmeh disabled auto-merge June 5, 2025 10:48
@arminmeh arminmeh merged commit a9bb071 into mui:master Jun 5, 2025
27 of 28 checks passed
@arminmeh arminmeh deleted the fix-node20 branch June 5, 2025 10:48
@cherniavskii
Copy link
Member

@arminmeh we need to cherry-pick it, right?

@arminmeh
Copy link
Contributor Author

arminmeh commented Jun 5, 2025

@cherniavskii
Cherry-pick of the previous one is not merged yet
#18217
and it includes this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenanYusuf KenanYusuf KenanYusuf approved these changes

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
feature: State management Related to the data grid State management feature scope: data grid Changes or issues related to the data grid product type: regression A bug that reintroduces previously resolved issues or breaks existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arminmeh @mui-bot @cherniavskii @KenanYusuf