Skip to content

[code-infra] Revert React to 19.0.0 #18265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jun 6, 2025

Revert #18166 with the hope to increase CI stability (avoid flaky browser tests and Netlify deploys).

@LukasTy LukasTy self-assigned this Jun 6, 2025
@LukasTy LukasTy added type: enhancement This is not a bug, nor a new feature scope: code-infra Specific to the code-infra product labels Jun 6, 2025
@@ -81,9 +81,9 @@
"nprogress": "^0.2.0",
"postcss": "^8.5.4",
"prop-types": "^15.8.1",
"react": "^19.1.0",
"react": "19.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed ^, since otherwise subsequent install would again reinstall 19.1.0 if it exists in pnpm store.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use ~19.0.0 in case a patch version is released

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use ~19.0.0 in case a patch version is released

~ Doesn't increment the minor, so it wouldn't matter anyways

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renovate will still suggest a patch release.
If we want to not see any info about updates, we need renovate rule.
Do you think we should add it?
I'd say that for now, let's wait and re-evaluate. 🤞

@LukasTy LukasTy added the core Covers general upkeep, such as minor refactoring, typo fixes, or structural changes. label Jun 6, 2025
@mui-bot
Copy link

mui-bot commented Jun 6, 2025

Deploy preview: https://deploy-preview-18265--material-ui-x.netlify.app/

Bundle size report

Total Size Change:${\tiny{\color{green}▼}}$-40B(0.00%) - Total Gzip Change:${\tiny{\color{green}▼}}$-48B(0.00%)
Files: 120 total (0 added, 0 removed, 45 changed)

Show 45 more bundle changes

@mui/x-charts-proparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts-pro/BarChartProparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts-pro/ChartContainerProparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+3B(+0.01%)
@mui/x-charts-pro/ChartDataProviderProparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(0.00%)
@mui/x-charts-pro/FunnelChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(0.00%)
@mui/x-charts-pro/Heatmapparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+3B(0.00%)
@mui/x-charts-pro/LineChartProparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts-pro/PieChartProparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts-pro/RadarChartProparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+3B(+0.01%)
@mui/x-charts-pro/ScatterChartProparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(0.00%)
@mui/x-chartsparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts-pro/ChartsToolbarProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts-pro/ChartZoomSliderparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(-0.01%)
@mui/x-charts/BarChartparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts/ChartContainerparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(-0.01%)
@mui/x-charts/ChartDataProviderparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts/ChartsAxisparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(-0.01%)
@mui/x-charts/ChartsAxisHighlightparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(-0.01%)
@mui/x-charts/ChartsClipPathparsed:${\tiny{\color{green}▼}}$-2B(-0.03%) gzip:${\tiny{\color{green}▼}}$-4B(-0.13%)
@mui/x-charts/ChartsGridparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts/ChartsLegendparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts/ChartsOverlayparsed:${\tiny{\color{green}▼}}$-2B(-0.02%) gzip:${\tiny{\color{green}▼}}$-2B(-0.06%)
@mui/x-charts/ChartsReferenceLineparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts/ChartsSurfaceparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts/ChartsTooltipparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(-0.01%)
@mui/x-charts/ChartsXAxisparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(-0.01%)
@mui/x-charts/ChartsYAxisparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(-0.01%)
@mui/x-charts/Gaugeparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts/LineChartparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts/PieChartparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%)
@mui/x-charts/RadarChartparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%)
@mui/x-charts/ScatterChartparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%)
@mui/x-charts/SparkLineChartparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-tree-viewparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(-0.01%)
@mui/x-tree-view-proparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-tree-view-pro/RichTreeViewProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-tree-view/RichTreeViewparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(-0.01%)
@mui/x-tree-view/SimpleTreeViewparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(-0.01%)
@mui/x-tree-view/TreeItemparsed:${\tiny{\color{green}▼}}$-2B(-0.01%) gzip:${\tiny{\color{green}▼}}$-2B(-0.02%)
@mui/x-tree-view/TreeItemProviderparsed:${\tiny{\color{green}▼}}$-2B(-0.03%) gzip:${\tiny{\color{green}▼}}$-2B(-0.07%)
@mui/x-data-gridparsed: 0B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-data-grid-premiumparsed: 0B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%)
@mui/x-data-grid-premium/DataGridPremiumparsed: 0B(0.00%) gzip:${\tiny{\color{green}▼}}$-3B(0.00%)
@mui/x-data-grid-proparsed: 0B(0.00%) gzip:${\tiny{\color{green}▼}}$-6B(0.00%)
@mui/x-data-grid-pro/DataGridProparsed: 0B(0.00%) gzip:${\tiny{\color{green}▼}}$-4B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 1a6801f

@LukasTy LukasTy added dependencies Update of dependencies and removed core Covers general upkeep, such as minor refactoring, typo fixes, or structural changes. labels Jun 6, 2025
@LukasTy LukasTy requested a review from a team June 6, 2025 10:38
@LukasTy LukasTy merged commit 0f6b967 into mui:master Jun 6, 2025
27 of 31 checks passed
@LukasTy LukasTy deleted the revert-react-bump branch June 6, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies scope: code-infra Specific to the code-infra product type: enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants