-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[code-infra] Revert React
to 19.0.0
#18265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -81,9 +81,9 @@ | |||
"nprogress": "^0.2.0", | |||
"postcss": "^8.5.4", | |||
"prop-types": "^15.8.1", | |||
"react": "^19.1.0", | |||
"react": "19.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed ^
, since otherwise subsequent install would again reinstall 19.1.0
if it exists in pnpm store.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use ~19.0.0
in case a patch version is released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use
~19.0.0
in case a patch version is released
~
Doesn't increment the minor, so it wouldn't matter anyways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renovate will still suggest a patch release.
If we want to not see any info about updates, we need renovate rule.
Do you think we should add it?
I'd say that for now, let's wait and re-evaluate. 🤞
Deploy preview: https://deploy-preview-18265--material-ui-x.netlify.app/ Bundle size reportTotal Size Change: Show 45 more bundle changes@mui/x-charts-pro parsed: |
Revert #18166 with the hope to increase CI stability (avoid flaky browser tests and Netlify deploys).