syntax: apply BinaryNextLine to test and arithmetic expressions#1332
Open
kimjune01 wants to merge 1 commit into
Open
syntax: apply BinaryNextLine to test and arithmetic expressions#1332kimjune01 wants to merge 1 commit into
kimjune01 wants to merge 1 commit into
Conversation
Fixes mvdan#813. The -bn flag now moves binary operators (&&, ||, +, etc.) to the start of the next line for BinaryTest, AndTest, OrTest inside [[ ]] and BinaryArithm inside $(( )), matching the existing BinaryCmd behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #813.
The
-bnflag moves binary operators to the start of the next line for pipes and logical operators in commands, but didn't apply to[[ ]]test expressions or$(( ))arithmetic expressions. This meantshfmt -bnwould reformat operators back to the end of the line in those contexts.Handle
BinaryTest(&&,||) andBinaryArithm(+, etc.) the same wayBinaryCmdalready works: when the operand spans multiple lines, move the operator to the beginning of the continuation line with proper indentation.Test cases cover single-line (unchanged), two-operand, three-operand chaining, and the exact example from the issue.