Skip to content

interp: handle bash >|, >>|, &>|, &>>|, <> redirects #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qiangli wants to merge 1 commit into
base: master
Choose a base branch
from
+40 −7
Open

interp: handle bash >|, >>|, &>|, &>>|, <> redirects #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions interp/interp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,6 +1469,26 @@ var runTests = []runTest{
"{ echo a; echo b >&2; } &>/dev/null",
"",
},
{
// >| force-overwrite; equivalent to > when noclobber is unset.
"echo foo >| a; cat a",
"foo\n",
},
{
// >| overwrites an existing file.
"echo foo >a; echo bar >| a; cat a",
"bar\n",
},
{
// <> opens for read-write; the file must be readable as stdin.
"echo foo >a; cat <>a",
"foo\n",
},
{
// <> creates the target file if it does not exist.
"cat <>missing; ls missing",
"missing\n",
},
{
"sed 's/o/a/g' <<EOF\nfoo$foo\nEOF",
"faa\n",
Expand Down
27 changes: 20 additions & 7 deletions interp/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,8 +998,19 @@ func (r *Runner) redir(ctx context.Context, rd *syntax.Redirect) (io.Closer, err
}
return nil, nil
case syntax.RdrIn, syntax.RdrOut, syntax.AppOut,
syntax.RdrAll, syntax.AppAll:
// done further below
syntax.RdrAll, syntax.AppAll,
syntax.RdrClob, syntax.AppClob,
syntax.RdrAllClob, syntax.AppAllClob,
syntax.RdrInOut:
// done further below.
// The "Clob" variants (>|, >>|, &>|, &>>|) bypass the noclobber
// shell option (set -C). Since this interpreter does not enforce
// noclobber on file redirects, they are functionally identical to
// their plain counterparts.
// RdrInOut (<>) opens the target file for read+write and binds it
// to the input fd (default 0); we read from the resulting file as
// stdin. Writes back through fd 0 are not propagated to the file
// since stdin is plumbed as io.Reader internally.
case syntax.DplIn:
switch arg {
case "-":
Expand All @@ -1013,25 +1024,27 @@ func (r *Runner) redir(ctx context.Context, rd *syntax.Redirect) (io.Closer, err
}
mode := os.O_RDONLY
switch rd.Op {
case syntax.AppOut, syntax.AppAll:
case syntax.AppOut, syntax.AppAll, syntax.AppClob, syntax.AppAllClob:
mode = os.O_WRONLY | os.O_CREATE | os.O_APPEND
case syntax.RdrOut, syntax.RdrAll:
case syntax.RdrOut, syntax.RdrAll, syntax.RdrClob, syntax.RdrAllClob:
mode = os.O_WRONLY | os.O_CREATE | os.O_TRUNC
case syntax.RdrInOut:
mode = os.O_RDWR | os.O_CREATE
}
f, err := r.open(ctx, arg, mode, 0o644, true)
if err != nil {
return nil, err
}
switch rd.Op {
case syntax.RdrIn:
case syntax.RdrIn, syntax.RdrInOut:
stdin, err := stdinFile(f)
if err != nil {
return nil, err
}
r.stdin = stdin
case syntax.RdrOut, syntax.AppOut:
case syntax.RdrOut, syntax.AppOut, syntax.RdrClob, syntax.AppClob:
*orig = f
case syntax.RdrAll, syntax.AppAll:
case syntax.RdrAll, syntax.AppAll, syntax.RdrAllClob, syntax.AppAllClob:
r.stdout = f
r.stderr = f
default:
Expand Down