feat(Vector Store Retriever Node): Add reranker support to retriever for QA chain #16051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schrothbn
requested review from
a team and
burivuhster
and removed request for
a team
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 12 issues across 5 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
...nodes-langchain/nodes/retrievers/RetrieverVectorStore/test/RetrieverVectorStore.node.test.ts
Show resolved
Hide resolved
...nodes-langchain/nodes/retrievers/RetrieverVectorStore/test/RetrieverVectorStore.node.test.ts
Show resolved
Hide resolved
...nodes-langchain/nodes/retrievers/RetrieverVectorStore/test/RetrieverVectorStore.node.test.ts
Show resolved
Hide resolved
...nodes-langchain/nodes/retrievers/RetrieverVectorStore/test/RetrieverVectorStore.node.test.ts
Show resolved
Hide resolved
...es-langchain/nodes/vector_store/shared/createVectorStoreNode/operations/retrieveOperation.ts
Show resolved
Hide resolved
...des/vector_store/shared/createVectorStoreNode/operations/__tests__/retrieveOperation.test.ts
Show resolved
Hide resolved
...ages/@n8n/nodes-langchain/nodes/retrievers/RetrieverVectorStore/RetrieverVectorStore.node.ts
Show resolved
Hide resolved
...ages/@n8n/nodes-langchain/nodes/retrievers/RetrieverVectorStore/RetrieverVectorStore.node.ts
Show resolved
Hide resolved
...ages/@n8n/nodes-langchain/nodes/retrievers/RetrieverVectorStore/RetrieverVectorStore.node.ts
Show resolved
Hide resolved
...ages/@n8n/nodes-langchain/nodes/retrievers/RetrieverVectorStore/RetrieverVectorStore.node.ts
Show resolved
Hide resolved
schrothbn
force-pushed
the
ai-1019-add-reranker-support-to-retrieverqa-chain
branch
from
9cf7b0f to
6445d1b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 04m 12s |
| Commit |
|
| Committer | Benjamin Schroth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
503
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Jun 11, 2025
Closed
Closed
Merged
|
Got released with |
TianYi0217
pushed a commit
to TianYi0217/n8n
that referenced
this pull request
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for rerankers in the retrieve operation of vector stores that's used by QA chain nodes.
Changes in retrieve operation:
Changes in Vector Store Retriever Node:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/AI-1019/add-reranker-support-to-retrieverqa-chain
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)