fix(editor): Maintain back button when installing community nodes #16069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the back button from disappearing
Since official community nodes are now part of mergedNodes, we need to alert the view stack to update
dana-gill
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 1 issue across 2 files. Review it in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeDetails.vue
Show resolved
Hide resolved
ShireenMissi
approved these changes
Jun 6, 2025
|
✅ All Cypress E2E specs passed |
dana-gill
deleted the
node-3034-when-installing-an-official-verified-node-on-1941-and-above
branch
This was referenced Jun 11, 2025
Closed
Closed
Merged
|
Got released with |
TianYi0217
pushed a commit
to TianYi0217/n8n
that referenced
this pull request
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Maintain back button when installing community nodes. The problem was that verified official community nodes are now part of the
visibleNodeTypes(see https://linear.app/n8n/issue/NODE-3009/distinguish-official-verified-nodes-from-community-built-ones) and we weren't updatingmergedNodes, which is derived fromvisibleNodeTypes.Updating
mergedNodeshas to be done manually since the root view stack only passes themergedNodesas a value (ie: It is not areforcomputed). Without doing a manual update, the problem would only be solved for unofficial verified nodes. Hence, we need to manually update the stack to solve the problem for both unofficial verified community nodes and official verified community nodes.We do not need to worry about unverified nodes because they are not in Strapi, and they do not get displayed in the Node Creator panel.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-3034/when-installing-an-official-verified-node-on-1941-and-above-the-nodes
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)