Skip to content

feat(editor): Enable source environment push button for project admins #15527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

guillaumejacquart
Copy link
Contributor

@guillaumejacquart guillaumejacquart commented May 19, 2025

⚠️ Should not be merged before this ticket is done: https://linear.app/n8n/issue/PAY-2826/validate-when-attempting-to-commit-from-modal-what-a-user-has-access

Summary

Currently, only instance owners and admins can see the push / pull button in the source control section of the side menu.
We want to enable project admins to push (not pull) to instances the changes related to the resources they have access to (workflows, credentials, tags, folder of the project they are admin of).
This PR does 2 things:

  • it show the souce control section of the side menu for project admins, with disabled pull button with tooltip to show why pull is disabled
  • it also displays the push button even if the instance is protected, with a tooltip explaning why

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/PAY-2824/show-push-button-for-project-admins#comment-c702d776

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tor-ui/src/components/MainSidebarSourceControl.vue 92.59% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label May 19, 2025
@guillaumejacquart guillaumejacquart force-pushed the pay-2824-show-push-button-for-project-admins branch from c45c1aa to 36f7034 Compare May 20, 2025 11:06
@guillaumejacquart guillaumejacquart changed the title wip feat(editor): Enable source environment push button for project admins May 20, 2025
@guillaumejacquart guillaumejacquart force-pushed the pay-2824-show-push-button-for-project-admins branch from 36f7034 to 24dea4e Compare May 20, 2025 11:25
@guillaumejacquart guillaumejacquart marked this pull request as ready for review May 22, 2025 12:22
@guillaumejacquart guillaumejacquart requested a review from afitzek May 22, 2025 12:22
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 4 files and found no issues. Review PR in cubic.dev.

@guillaumejacquart guillaumejacquart force-pushed the pay-2824-show-push-button-for-project-admins branch from 24dea4e to 1f39348 Compare June 3, 2025 10:03
Copy link
Contributor

@afitzek afitzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@shortstacked
Copy link
Contributor

Workflow Test Results 📊 🔴 1 Failed, ⚠️ 4 Warnings, 👍 78 Successful out of 83 total workflows.

Detail: Workflows failing: 237: Workflow contains 1 deleted data. View full workflow run

Tested Ref: 1f39348e90432b169cfde23b92db8ee2db3be85e by @afitzek

❌ Failed Tests (1)

Workflow ID Workflow Name Reason
237 BasicLLMChain:AzureChat Workflow contains 1 deleted data.

⚠️ Warnings (4)

Workflow ID Workflow Name Reason
35 Slack:User:getPresence info:UserProfile:get update... Workflow contains new data that previously did not exist.
48 Asana:Project:getAll get:Task:create update move g... Workflow contains new data that previously did not exist.
53 ConvertKit:CustomField:create getAll update delete... Workflow contains new data that previously did not exist.
257 Agent:auto-fix:anthropic Workflow contains new data that previously did not exist.

Copy link
Contributor

github-actions bot commented Jun 3, 2025

✅ All Cypress E2E specs passed

@guillaumejacquart guillaumejacquart merged commit 2f64809 into master Jun 3, 2025
35 checks passed
@guillaumejacquart guillaumejacquart deleted the pay-2824-show-push-button-for-project-admins branch June 3, 2025 12:18
Alexandero89 pushed a commit to Alexandero89/n8n that referenced this pull request Jun 4, 2025
Alexandero89 pushed a commit to Alexandero89/n8n that referenced this pull request Jun 4, 2025
@janober
Copy link
Member

janober commented Jun 11, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants