-
Notifications
You must be signed in to change notification settings - Fork 34.1k
feat(editor): Enable source environment push button for project admins #15527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Enable source environment push button for project admins #15527
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
c45c1aa
to
36f7034
Compare
36f7034
to
24dea4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic reviewed 4 files and found no issues. Review PR in cubic.dev.
24dea4e
to
1f39348
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Workflow Test Results 📊 🔴 1 Failed,
|
Workflow ID | Workflow Name | Reason |
---|---|---|
237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
⚠️ Warnings (4)
Workflow ID | Workflow Name | Reason |
---|---|---|
35 | Slack:User:getPresence info:UserProfile:get update... | Workflow contains new data that previously did not exist. |
48 | Asana:Project:getAll get:Task:create update move g... | Workflow contains new data that previously did not exist. |
53 | ConvertKit:CustomField:create getAll update delete... | Workflow contains new data that previously did not exist. |
257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
✅ All Cypress E2E specs passed |
Got released with |
Summary
Currently, only instance owners and admins can see the push / pull button in the source control section of the side menu.
We want to enable project admins to push (not pull) to instances the changes related to the resources they have access to (workflows, credentials, tags, folder of the project they are admin of).
This PR does 2 things:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2824/show-push-button-for-project-admins#comment-c702d776
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)