Skip to content

perf(core): Load source control only if licensed #15908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 2, 2025

Summary

Load source control only if licensed, for less resource usage.

Excluded variables controller, as it might still be needed for users who should retain read access to variables after license expiration.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic found 4 issues across 1 file. Review them in cubic.dev

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/server.ts 0.00% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ivov ivov requested a review from guillaumejacquart June 2, 2025 08:27
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 2, 2025
Copy link
Contributor

@guillaumejacquart guillaumejacquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
Tried with and without the license enabled, no issues spotted

@shortstacked
Copy link
Contributor

Workflow Test Results 📊 ⚠️ 3 Warnings (0 Failed), 👍 80 Successful out of 83 total workflows.

View full workflow run

Tested Ref: 6b57fc546105ae74bd6c6831addcc00666bfa113 by @guillaumejacquart

⚠️ Warnings (3)

Workflow ID Workflow Name Reason
237 BasicLLMChain:AzureChat Requests to the ChatCompletions_Create Operation under Azure OpenAI API version 2025-03-01-preview have exceeded token rate limit of your current Open...
35 Slack:User:getPresence info:UserProfile:get update... Workflow contains new data that previously did not exist.
257 Agent:auto-fix:anthropic Workflow contains new data that previously did not exist.

Copy link
Contributor

github-actions bot commented Jun 2, 2025

✅ All Cypress E2E specs passed

@ivov ivov merged commit d7e94eb into master Jun 2, 2025
48 checks passed
@ivov ivov deleted the load-source-control-only-if-licensed branch June 2, 2025 14:38
Alexandero89 pushed a commit to Alexandero89/n8n that referenced this pull request Jun 4, 2025
Alexandero89 pushed a commit to Alexandero89/n8n that referenced this pull request Jun 4, 2025
@janober
Copy link
Member

janober commented Jun 11, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants