feat(Structured Output Parser Node): Add auto-fix support to Strucutred Output Parser #15915
Conversation
…output parser nodes
| @@ -163,7 +173,7 @@ function onCommunityNodeTooltipClick(event: MouseEvent) { | |||
| :is-trigger="isTrigger" | |||
| :is-official="isOfficial" | |||
| :data-test-id="dataTestId" | |||
| :tag="nodeType.tag" | |||
There was a problem hiding this comment.
nodeType.tag was typed string | undefined but this component expects an object, so I don't think this would've worked before - but it also looks like no nodes used this mechanism. I did fix the typing issue on the computed value now.
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 11 issues across 6 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
...8n/nodes-langchain/nodes/output_parser/OutputParserStructured/OutputParserStructured.node.ts
Show resolved
Hide resolved
...8n/nodes-langchain/nodes/output_parser/OutputParserStructured/OutputParserStructured.node.ts
Show resolved
Hide resolved
...8n/nodes-langchain/nodes/output_parser/OutputParserStructured/OutputParserStructured.node.ts
Show resolved
Hide resolved
| @@ -0,0 +1,16 @@ | |||
| export const NAIVE_FIX_PROMPT = `Instructions: | |||
There was a problem hiding this comment.
Duplicate implementation of NAIVE_FIX_PROMPT that already exists in other files. Consider importing from a shared location instead of duplicating.
| export const NAIVE_FIX_PROMPT = `Instructions: | |
| export { NAIVE_FIX_PROMPT } from '../../../utils/output_parsers/prompt'; |
There was a problem hiding this comment.
Intentionally took a copy of it to make this independent of the old auto-fixing node.
...angchain/nodes/output_parser/OutputParserStructured/test/OutputParserStructured.node.test.ts
Show resolved
Hide resolved
...angchain/nodes/output_parser/OutputParserStructured/test/OutputParserStructured.node.test.ts
Show resolved
Hide resolved
packages/frontend/editor-ui/src/components/Node/NodeCreator/ItemTypes/NodeItem.vue
Show resolved
Hide resolved
packages/frontend/editor-ui/src/components/Node/NodeCreator/ItemTypes/NodeItem.vue
Show resolved
Hide resolved
packages/frontend/editor-ui/src/components/Node/NodeCreator/ItemTypes/NodeItem.vue
Show resolved
Hide resolved
packages/frontend/editor-ui/src/components/Node/NodeCreator/ItemTypes/NodeItem.vue
Show resolved
Hide resolved
| inputs: [], | ||
| inputs: `={{ | ||
| ((parameters) => { | ||
| if (parameters?.autoFix) { |
There was a problem hiding this comment.
Nice, I think we really need to work on the inputs being loaded dynamically in the NDV.
| @@ -163,7 +173,7 @@ function onCommunityNodeTooltipClick(event: MouseEvent) { | |||
| :is-trigger="isTrigger" | |||
| :is-official="isOfficial" | |||
| :data-test-id="dataTestId" | |||
| :tag="nodeType.tag" | |||
Workflow Test Results 📊 🔴 2 Failed,
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
| 258 | Agent:auto-fix:openai | Workflow contains 2 deleted data. |
⚠️ Warnings (4)
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 35 | Slack:User:getPresence info:UserProfile:get update... | Workflow contains new data that previously did not exist. |
| 53 | ConvertKit:CustomField:create getAll update delete... | Workflow contains new data that previously did not exist. |
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
| 48 | Asana:Project:getAll get:Task:create update move g... | Workflow contains new data that previously did not exist. |
|
✅ All Cypress E2E specs passed |
Cadiac
deleted the
ado-3549-spike-merge-auto-fixing-and-structured-output-nodes
branch
|
Got released with |
Summary
This PR merges
Auto-fixing Output Parserauto-fix functionality toStructured Output Parsernode. User can now turn on Auto-Fix on these nodes, and optionally provide a custom prompt instructions for fixing the output like on the auto-fixing node. If Auto-Fix mode is enabled a Model input has to be connected to the node.autofix.mp4
With this change
Auto-fixing Output Parseris should be considered deprecated, as theStructured Output Parsernow offers the same functionality. The old node is still kept available for now, with a 'Deprecated' tag on it and we may remove it in the future.This is the first time we're displaying such 'Deprecated' tag - to display it, make node's description contain string "deprecated". In future we may want to add a way to add tags node definitions.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3549/merge-auto-fixing-and-structured-output-nodes
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)