feat(Structured Output Parser Node): Mark all parameters as required for schemas generated from JSON example #15935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 7 issues across 8 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
...8n/nodes-langchain/nodes/output_parser/OutputParserStructured/OutputParserStructured.node.ts
Outdated
Show resolved
Hide resolved
packages/@n8n/nodes-langchain/utils/output_parsers/N8nStructuredOutputParser.ts
Show resolved
Hide resolved
burivuhster
requested review from
a team,
OlegIvaniv and
ggozad
and removed request for
a team
…onExtractor and ToolCode
burivuhster
force-pushed
the
ai-980-allow-for-json-schemas-generated-from-example-be-marked-as
branch
from
19eb2a1 to
f6d1623
Compare
burivuhster
changed the title
ggozad
reviewed
Jun 5, 2025
Workflow Test Results 📊 🔴 2 Failed,
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
| 84 | Matrix:Room:create invite kick leave:RoomMember:ge... | Too Many Requests on node Matrix1 |
⚠️ Warnings (3)
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 35 | Slack:User:getPresence info:UserProfile:get update... | Workflow contains new data that previously did not exist. |
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
| 48 | Asana:Project:getAll get:Task:create update move g... | Workflow contains new data that previously did not exist. |
|
✅ All Cypress E2E specs passed |
burivuhster
deleted the
ai-980-allow-for-json-schemas-generated-from-example-be-marked-as
branch
This was referenced Jun 11, 2025
Closed
Closed
Merged
|
Got released with |
TianYi0217
pushed a commit
to TianYi0217/n8n
that referenced
this pull request
Jun 14, 2025
…for schemas generated from JSON example (n8n-io#15935)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the JSON schema generation from JSON example. It marks all the properties as required recursively.
This logic affects the following nodes:
The new behavior will be enabled for the new versions of each node.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)