fix(editor): Fix regExp to allow "." in Git repository URL (SSH) #15972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r00gm
commented
Jun 3, 2025
| @@ -134,7 +134,7 @@ const repoUrlValidationRules: Array<Rule | RuleGroup> = [ | |||
| name: 'MATCH_REGEX', | |||
| config: { | |||
| regex: | |||
| /^(?:git@|ssh:\/\/git@|[\w-]+@)(?:[\w.-]+|\[[0-9a-fA-F:]+])(?::\d+)?[:\/][\w\-~]+(?:\/[\w\-~]+)*(?:\.git)?(?:\/.*)?$/, | |||
| /^(?:git@|ssh:\/\/git@|[\w-]+@)(?:[\w.-]+|\[[0-9a-fA-F:]+])(?::\d+)?[:\/][\w\-~.]+(?:\/[\w\-~.]+)*(?:\.git)?(?:\/.*)?$/, | |||
There was a problem hiding this comment.
@cstuncsik this is the only change, everything else is formatting
r00gm
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 2 files and found no issues. Review PR in cubic.dev.
cstuncsik
approved these changes
Jun 3, 2025
Workflow Test Results 📊 🔴 2 Failed,
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
| 258 | Agent:auto-fix:openai | Workflow contains 2 deleted data. |
⚠️ Warnings (4)
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 35 | Slack:User:getPresence info:UserProfile:get update... | Workflow contains new data that previously did not exist. |
| 53 | ConvertKit:CustomField:create getAll update delete... | Workflow contains new data that previously did not exist. |
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
| 48 | Asana:Project:getAll get:Task:create update move g... | Workflow contains new data that previously did not exist. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
✅ All Cypress E2E specs passed |
r00gm
deleted the
pay-2903-community-issue-issues-with-field-validation-on-git
branch
Alexandero89
pushed a commit
to Alexandero89/n8n
that referenced
this pull request
Jun 4, 2025
Alexandero89
pushed a commit
to Alexandero89/n8n
that referenced
this pull request
Jun 4, 2025
This was referenced Jun 11, 2025
Closed
Closed
Merged
|
Got released with |
TianYi0217
pushed a commit
to TianYi0217/n8n
that referenced
this pull request
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the regular expression validating the Git repository URL (SSH) to allow "."
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2903/community-issue-issues-with-field-validation-on-git-repository-url-ssh
resolves #15958
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)