Skip to content

fix: Make sure modals are listed when using a free AI credits credential in the OpenAI node #16030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Jun 4, 2025

Summary

We filter out all models that do not come from api.openai.com. Since the models for free AI credits come from ai-assistant.n8n.io, they are currently being filtered out. This PR hardcodes the AI assistant URL so that these models are no longer excluded.

For more context see -> https://n8nio.slack.com/archives/C07BV4T1P6Y/p1743554653872829

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-3610/bug-models-do-not-load-when-using-the-n8n-free-openai-api-credits

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ngchain/nodes/vendors/OpenAi/methods/listSearch.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 4, 2025
@RicardoE105 RicardoE105 changed the title Make sure modals are listed when using a free AI credits credential fixL Make sure modals are listed when using a free AI credits credential Jun 4, 2025
@RicardoE105 RicardoE105 changed the title fixL Make sure modals are listed when using a free AI credits credential fix: Make sure modals are listed when using a free AI credits credential Jun 4, 2025
@RicardoE105 RicardoE105 marked this pull request as ready for review June 4, 2025 20:46
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 1 file and found no issues. Review PR in cubic.dev.

@RicardoE105 RicardoE105 changed the title fix: Make sure modals are listed when using a free AI credits credential fix: Make sure modals are listed when using a free AI credits credential in the OpenAI node Jun 5, 2025
@RicardoE105 RicardoE105 requested a review from Cadiac June 5, 2025 16:42
Copy link
Contributor

@Cadiac Cadiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the issue exists - and this seems like it should fix it, nice job catching this 👍

Copy link
Contributor

github-actions bot commented Jun 6, 2025

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 7f7b44a into master Jun 6, 2025
49 of 55 checks passed
@RicardoE105 RicardoE105 deleted the ado-3610-bug-models-do-not-load-when-using-the-n8n-free-openai-api branch June 6, 2025 16:09
Copy link

cypress bot commented Jun 7, 2025

n8n    Run #11361

Run Properties:  status check passed Passed #11361  •  git commit 7f7b44ae7c: 🌳 master 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #11361
Run duration 04m 20s
Commit git commit 7f7b44ae7c: 🌳 master 🤖 PR User 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 503
View all changes introduced in this branch ↗︎

@janober
Copy link
Member

janober commented Jun 11, 2025

Got released with [email protected]

TianYi0217 pushed a commit to TianYi0217/n8n that referenced this pull request Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants