fix(core): Fix HTTP proxy support in all nodes and other axios requests #16092
+246
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 5 files and found no issues. Review PR in cubic.dev.
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
|
✅ All Cypress E2E specs passed |
dana-gill
requested changes
Jun 6, 2025
Comment on lines
-27104
to
+27113
| debug: 3.2.7(supports-color@5.5.0) | ||
| debug: 3.2.7(supports-color@8.1.1) |
There was a problem hiding this comment.
It looks like there are dependencies here which shouldn't be updated 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix support for HTTP(s) proxies
HTTP_PROXY/HTTPS_PROXY/ALL_PROXY/NO_PROXYenv varsproxy-from-env(same package as axios)Tested with tinyproxy
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2942/http-request-node-proxy-issue
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)