golangci-lint 2.0 compatability issue

[kirillrdy]

when running tests against golangci-lint 2.0 get the following error

-- FAIL: TestLangHandler_lint_Integration (0.23s)
    --- FAIL: TestLangHandler_lint_Integration/no_config_file (0.05s)
        handler_test.go:181: lint() mismatch (-want +got):
              []main.Diagnostic{
            -   {
            -           Range: main.Range{
            -                   Start: main.Position{Line: 3, Character: 4},
            -                   End:   main.Position{Line: 3, Character: 4},
            -           },
            -           Severity: 2,
            -           Source:   &"unused",
            -           Message:  "unused: var `foo` is unused",
            -   },
            +   {
            +           Severity: 1,
            +           Message:  "Error: unknown flag: --out-format\nFailed executing command with error: unknown flag: --out-format\n",
            +   },
              }

[nataziel]

The output format specification will need to changed to --output.json.path stdout, so the invocation in that test should be:
[]string{"golangci-lint", "run", "--output.json.path", "stdout", "--issues-exit-code", "1"}

There's also a (separate) complication with v2 now that show-stats is enabled by default that makes the output to stdout have text appended to the end of the json. There doesn't seem to be a way to turn it off at the CLI as far as I can tell. (need to use --show-stats=false

[nataziel]

I was able to get the language server running and getting the right output from golangci-lint by specifying this command:

golangci-lint run --output.json.path stdout --show-stats=false --issues-exit-code 1

[jinzhongjia]

I was able to get the language server running and getting the right output from golangci-lint by specifying this command:

golangci-lint run --output.json.path stdout --show-stats=false --issues-exit-code 1

It seems to be invalid to me, after I set this to cmd of lspconfig, it exits directly
This forced me to disable it temporarily

[upryst]

This worked for me in Helix, ~/.config/helix/languages.toml:

[language-server.golangci-lint-lsp.config]
command = ["golangci-lint", "run", "--output.json.path", "stdout", "--show-stats=false", "--issues-exit-code=1"]

[jonathan-conder]

It seems to be invalid to me, after I set this to cmd of lspconfig, it exits directly This forced me to disable it temporarily

For nvim-lspconfig, the cmd should remain golangci-lint-langserver, which is the default.

Use init_options = {command = {'golangci-lint', ...}} instead.

[wavded]

golangci_lint_ls = {
  init_options = {
    cmd = { "golangci-lint-langserver" },
    root_dir = util.root_pattern(".git", "go.mod"),
    command = {
      "golangci-lint",
      "run",
      "--output.json.path",
      "stdout",
      "--show-stats=false",
      "--issues-exit-code=1",
    },
  },
},

With this config I'm getting:

[ERROR][2025-03-25 15:15:13] .../vim/lsp/rpc.lua:770	"rpc"	"/Users/foo/.local/share/nvim/mason/bin/golangci-lint-langserver"	"stderr"	"golangci-lint-langserver: connections opened\n"

[ERROR][2025-03-25 15:22:20] .../vim/lsp/rpc.lua:770	"rpc"	"/Users/foo/.local/share/nvim/mason/bin/golangci-lint-langserver"	"stderr"	'2025/03/25 15:22:20 jsonrpc2 handler: notification "exit" handling error: jsonrpc2: code -32601 message: method not supported: exit\n'

[jinzhongjia]

for neovim lspconfig users: just add this to your server opts:

init_options = {
    command = {
        "golangci-lint",
        "run",
        "--output.json.path",
        "stdout",
        "--show-stats=false",
        "--issues-exit-code=1",
    },
}

[kirillrdy]

fix for tests #52