Fix crasher on callout for a leafnode connection with hand-rolled creds that are mistmatched#7844
Merged
neilalexander merged 2 commits intomainfrom Feb 18, 2026
Merged
Fix crasher on callout for a leafnode connection with hand-rolled creds that are mistmatched#7844neilalexander merged 2 commits intomainfrom
neilalexander merged 2 commits intomainfrom
Conversation
…ds that are mistmatched Signed-off-by: Alberto Ricart <alberto@synadia.com>
derekcollison
approved these changes
Feb 17, 2026
Member
derekcollison
left a comment
derekcollison
left a comment
There was a problem hiding this comment.
LGTM - One nit to put full issue URL in the comment.
server/auth_callout.go
Outdated
| acc = c.acc | ||
| } | ||
| if acc == nil { | ||
| // FIX for 7841 - hand rolled creds on leafnode became crasher here |
Member
There was a problem hiding this comment.
Put full issue URL here..
Signed-off-by: Alberto Ricart <alberto@synadia.com>
neilalexander
added a commit
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is leafnode scenario only with bad creds rolled for the leafnode (jwt and nkey don't match so user cannot be placed into the account as the user validation fails, but the callout is delegated for verification.
Fixes #7841
Signed-off-by: Your Name alberto@synadia.com