Skip to content

memstore: refresh stale Last values and hold write lock in MultiLastSeqs#7865

Merged
neilalexander merged 1 commit intomainfrom
memstore-fix-stale-last-usage
Feb 24, 2026
Merged

memstore: refresh stale Last values and hold write lock in MultiLastSeqs#7865
neilalexander merged 1 commit intomainfrom
memstore-fix-stale-last-usage

Conversation

@sciascid
Copy link
Copy Markdown
Contributor

Avoid access to potentially stale ss.Last in MultiLastSeqs.

Signed-off-by: Daniele Sciascia daniele@nats.io

@sciascid sciascid requested a review from a team as a code owner February 23, 2026 09:32
Copy link
Copy Markdown
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you add a test for this?

Signed-off-by: Daniele Sciascia <daniele@nats.io>
@sciascid sciascid force-pushed the memstore-fix-stale-last-usage branch from 3dbde43 to a641b4e Compare February 23, 2026 10:05
Copy link
Copy Markdown
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit ad9642f into main Feb 24, 2026
111 of 114 checks passed
@neilalexander neilalexander deleted the memstore-fix-stale-last-usage branch February 24, 2026 10:28
neilalexander added a commit that referenced this pull request Feb 25, 2026
Includes the following:

- #7867
- #7865
- #7870
- #7874
- #7877

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants