[FIXED] Prevent stale consumer state losing consumers#7905
Merged
neilalexander merged 2 commits intomainfrom Mar 5, 2026
Merged
[FIXED] Prevent stale consumer state losing consumers#7905neilalexander merged 2 commits intomainfrom
neilalexander merged 2 commits intomainfrom
Conversation
When `processClusterCreateConsumer` applies initial state from a snapshot during recovery, `setStoreState` calls `store.Update` which can return `old update ignored` if the consumer already has newer state. Previously this error propagated up and caused the consumer to be stopped and its Raft node deleted, making it disappear. Signed-off-by: Waldemar Quevedo <wally@nats.io>
wallyqs
force-pushed
the
wq/consumer-snap-err
branch
from
c349505 to
a709932
Compare
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
wallyqs
changed the title
MauriceVanVeen
changed the title
Member
|
Could you also add a similar if err = o.store.Update(state); err != nil && err != ErrStoreOldUpdate { |
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
neilalexander
added a commit
that referenced
this pull request
Mar 5, 2026
Related to #7905, the meta snapshots should never contain `ca.State` as this is only used to signal updating to specific state in the apply path, not during recovery from a snapshot. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
zenozaga
pushed a commit
to zenozaga/nats-server
that referenced
this pull request
Mar 6, 2026
Related to nats-io#7905, the meta snapshots should never contain `ca.State` as this is only used to signal updating to specific state in the apply path, not during recovery from a snapshot. Signed-off-by: Maurice van Veen <github@mauricevanveen.com> Signed-off-by: Randy stiven Valentin <zenozaga@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
processClusterCreateConsumerapplies initial state from a consumer assignment with stale state,setStoreStatecallsstore.Updatecan return an error if the consumer already has newer state loaded from disk. Previously this error propagated up and caused the consumer to be stopped and its Raft node deleted, making it disappear after the server restarts after logging:This change adds a
ErrStoreOldUpdateerror which is now treated as a non-error insetStoreStatesince the consumer store would already have newer correct state.Signed-off-by: Waldemar Quevedo wally@nats.io