Skip to content

Fix account balance for dYdX #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Fix account balance for dYdX #2167

merged 1 commit into from
Jan 2, 2025

Conversation

davidsblom
Copy link
Member

Pull Request

Fix account balance for dYdX

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this change been tested?

Unit tests and live example

Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #2167 will degrade performances by 30.76%

Comparing dydx-balance (474a77d) with develop (90563d7)

Summary

❌ 1 regressions
✅ 52 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop dydx-balance Change
test_create_symbol 18.9 µs 27.3 µs -30.76%

@@ -315,6 +315,16 @@ async def _connect(self) -> None:
sequence=account.sequence,
)

while self.get_account() is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put a timeout on this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@cjdsellers cjdsellers merged commit 40d5817 into develop Jan 2, 2025
17 checks passed
@cjdsellers cjdsellers deleted the dydx-balance branch January 2, 2025 19:28
ryadavDeqode pushed a commit to Alfred-hq/nautilus_trader that referenced this pull request Jan 16, 2025
ryadavDeqode pushed a commit to Alfred-hq/nautilus_trader that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants