Skip to content

Add fee model to OrderMatchingEngine in Rust #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

Add fee model to OrderMatchingEngine in Rust #2191

merged 1 commit into from
Jan 7, 2025

Conversation

filipmacek
Copy link
Member

Pull Request

  • FeeModel was missing in the order matching engine, so adding it to the struct with the default variant of MakerTakerFeeModel in tests

@filipmacek filipmacek added the rust Relating to the Rust core label Jan 7, 2025
@filipmacek filipmacek requested a review from cjdsellers January 7, 2025 11:09
@filipmacek filipmacek self-assigned this Jan 7, 2025
@cjdsellers cjdsellers merged commit 9a8e201 into develop Jan 7, 2025
12 checks passed
@cjdsellers cjdsellers deleted the add-fee-model-order-matching-engine branch January 7, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdsellers cjdsellers cjdsellers approved these changes

Assignees

@filipmacek filipmacek

Labels
rust Relating to the Rust core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipmacek @cjdsellers