Skip to content

Betfair resubscribe on reconnect #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions nautilus_trader/adapters/betfair/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ async def connect(self) -> None:
self._log.info("Login success", color=LogColor.GREEN)
self.update_headers(login_resp=resp)

async def reconnect(self) -> None:
self._log.info("Reconnecting...")
self.reset_headers()
await self.connect()

async def disconnect(self) -> None:
self._log.info("Disconnecting...")
self.reset_headers()
Expand Down
13 changes: 8 additions & 5 deletions nautilus_trader/adapters/betfair/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,7 @@ async def _connect(self) -> None:
if not self._keep_alive_task:
self._keep_alive_task = self.create_task(self._keep_alive())

# Subscribe to instrument provider config
await self.stream_subscribe()
self._subscription_status = SubscriptionStatus.SUBSCRIBED

async def stream_subscribe(self):
# Subscribe to instrument provider config
Expand All @@ -169,6 +167,12 @@ async def _keep_alive(self) -> None:
self._log.debug("Canceled task 'keep_alive'")
return

async def _reconnect(self) -> None:
self._log.info("Reconnecting betfair data client")
await self._client.reconnect()
await self._stream.reconnect()
await self.stream_subscribe()

async def _disconnect(self) -> None:
# Cancel tasks
if self._keep_alive_task:
Expand Down Expand Up @@ -343,11 +347,10 @@ def _handle_status_message(self, update: Status) -> None:
self._log.info("Reconnect already in progress")
return
self._log.info("Invalid session information, reconnecting client")
self._client.reset_headers()
self.create_task(self._stream.reconnect())
self.create_task(self._reconnect())
else:
if self._stream.is_reconnecting():
self._log.info("Reconnect already in progress")
return
self._log.warning("Unknown API error, scheduling reconnect")
self.create_task(self._stream.reconnect())
self.create_task(self._reconnect())
3 changes: 3 additions & 0 deletions tests/integration_tests/adapters/betfair/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ def data_client(
"nautilus_trader.adapters.betfair.providers.BetfairInstrumentProvider._client.list_navigation",
return_value=BetfairResponses.navigation_list_navigation(),
)
mocker.patch(
"nautilus_trader.adapters.betfair.data.BetfairDataClient.stream_subscribe",
)

return data_client

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ async def test_connect(mocker, data_client, instrument):
# Arrange
mocker.patch("nautilus_trader.adapters.betfair.data.BetfairMarketStreamClient.connect")
mocker.patch("nautilus_trader.adapters.betfair.client.BetfairHttpClient.connect")
mocker.patch("nautilus_trader.adapters.betfair.client.BetfairHttpClient.connect")

# Act
data_client.connect()
Expand Down
Loading