Fix large difference between Data enum variants #2315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
The data enum has the orderbook depth variant which is significantly larger than other variants bloating memory footprint of all other variants. Boxing orderbook depth minimizes its footprint with minimal changes.
Type of change
How has this change been tested?
Before the change this test shows 10x increase in delta size.
1M deltas -> 103 MB
1M deltas (wrapped with Data) -> 1 GB
After the change
1M deltas -> 103 MB
1M deltas (wrapped with Data boxed Orderbook depth) -> 160 MB