Add instrument_ids and bar_types for BacktestDataConfig #2478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdsellers
changed the title
faysou
force-pushed
the
backtestdataconfig
branch
2 times, most recently
from
478a9a0 to
178ef90
Compare
faysou
force-pushed
the
backtestdataconfig
branch
from
178ef90 to
07dbcaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Refine BacktestDataConfig with instrument_ids and bar_types
Type of change
How has this change been tested?
Tested manually in databento_option_greeks.py for chunk_size = None and not None (I think chunk_size should be renamed to something better like batch_data_size else it's hard to know what it's doing except by looking at the code)