Improve zero size trade logging for Binance Futures #2588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdsellers
changed the title
cjdsellers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Binance sends empty trade tick messages from time to time. This leads to error messages and noise in logs:
Error handling trade tick message b'{"stream":"xrpusdt@trade","data":{"e":"trade","E":1746194730699,"T":1746194730699,"s":"XRPUSDT","t":2332526925,"p":"0","q":"0","X":"NA","m":false}}', 'size' not a positive integer, was 0Such messages should have
DEBUGlevel in logs.Type of change
How has this change been tested?
Manually