Improve ergonomics of messaging topics, patterns, and endpoints #2658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdsellers
changed the title
|
Great stuff, thanks @twitu |
stastnypremysl
pushed a commit
to stastnypremysl/nautilus_trader
that referenced
this pull request
May 30, 2025
…echsystems#2658) Use phantom types for more concise and ergonomic topic pattern API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Use phantom types for Topic pattern for a more ergonomic and concise api. It also draws from design principle that both types have the same physical representation but have different validation properties. Also merged endpoints and topics since they are physically and functionally the same.
Related Issues/PRs
#2646
Type of change