Binance Futures margin type #2660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdsellers
approved these changes
May 22, 2025
There was a problem hiding this comment.
👌 thanks for the contribution @bartolootrit!
Given we don't have good test coverage for the Binance adapter, and margin trading currently isn't possible afaik, it's OK that this doesn't have tests for now (something we're working to improve).
I'll handle the release notes update on this occasion.
stastnypremysl
pushed a commit
to stastnypremysl/nautilus_trader
that referenced
this pull request
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
/fapi/v1/marginTypeendpoint was added to change margin type from crossed to isolated and vice versaType of change
Release notes
RELEASES.mdthat follows the existing conventions (when applicable)Testing
It was tested manually on Binance Testnet and Mainnet.