Fix binance spot futures sandbox #2687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x' into feat/binance-spot-futures-sandbox
cjdsellers
changed the title
|
Hi @petioptrv Looks good and many thanks for the contribution! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.
Summary
This PR adds several tweaks to enable running on both Binance SPOT and FUTURES venues at the same time, including using the sandbox executioner for paper-trading with this configuration.
Related Issues/PRs
N/A
Type of change
Breaking change details (if applicable)
N/A
Release notes
RELEASES.mdthat follows the existing conventions (when applicable)Testing
Ensure new or changed logic is covered by tests.
I ensured that the
binance_spot_and_futures_market_maker.pyscript runs as intended, and I added a new script,binance_spot_futures_sandbox.py, to validate the use of the sandbox execution engine.