Skip to content

Fix value.low existence check when value is not an Object #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/chart/ChartUtils.ts
Original file line number Diff line number Diff line change
@@ -164,7 +164,7 @@ export const downloadCSV = (rows) => {
headers.forEach((header) => {
// Parse value
let value = row[header];
if (value && 'low' in value) {
if (value?.low !== undefined) {
value = value.low;
}
csv += `${JSON.stringify(value)}`;

Unchanged files with check annotations Beta

if (urlParams.get('credentials')) {
setWelcomeScreenOpen(false);
const connection = decodeURIComponent(urlParams.get('credentials'));
const protocol = connection.split('://')[0];

Check warning on line 267 in src/application/ApplicationThunks.ts

GitHub Actions / build-test (18.x)

Use array destructuring
const username = connection.split('://')[1].split(':')[0];

Check warning on line 268 in src/application/ApplicationThunks.ts

GitHub Actions / build-test (18.x)

Use array destructuring
const password = connection.split('://')[1].split(':')[1].split('@')[0];

Check warning on line 269 in src/application/ApplicationThunks.ts

GitHub Actions / build-test (18.x)

Use array destructuring
const database = connection.split('@')[1].split(':')[0];

Check warning on line 270 in src/application/ApplicationThunks.ts

GitHub Actions / build-test (18.x)

Use array destructuring
const url = connection.split('@')[1].split(':')[1];

Check warning on line 271 in src/application/ApplicationThunks.ts

GitHub Actions / build-test (18.x)

Use array destructuring
const port = connection.split('@')[1].split(':')[2];

Check warning on line 272 in src/application/ApplicationThunks.ts

GitHub Actions / build-test (18.x)

Use array destructuring
dispatch(setConnectionModalOpen(false));
dispatch(
dispatch(initializeApplicationAsEditorThunk(config, paramsToSetAfterConnecting));
}
} catch (e) {
console.log(e);

Check warning on line 561 in src/application/ApplicationThunks.ts

GitHub Actions / build-test (18.x)

Unexpected console statement
dispatch(setWelcomeScreenOpen(false));
dispatch(
createNotificationThunk(
() => {},
(records) => {
if (records && records[0] && records[0]._fields && records[0]._fields[0] && records[0]._fields[0] == uuid) {
console.log(`log created: ${uuid}`);

Check warning on line 36 in src/application/logging/LoggingThunk.ts

GitHub Actions / build-test (18.x)

Unexpected console statement
} else {
// we only show error notification one time
const state = getState();
const loggingSettings = applicationGetLoggingSettings(state);
let LogErrorNotificationNum = Number(loggingSettings.logErrorNotification);
console.log(`Error creating log for ${(LogErrorNotificationNum - 4) * -1} times`);

Check warning on line 42 in src/application/logging/LoggingThunk.ts

GitHub Actions / build-test (18.x)

Unexpected console statement
if (LogErrorNotificationNum > 0) {
dispatch(
createNotificationThunk(
const state = getState();
const loggingSettings = applicationGetLoggingSettings(state);
let LogErrorNotificationNum = Number(loggingSettings.logErrorNotification);
console.log(`Error creating log for ${(LogErrorNotificationNum - 4) * -1} times`);

Check warning on line 63 in src/application/logging/LoggingThunk.ts

GitHub Actions / build-test (18.x)

Unexpected console statement
if (LogErrorNotificationNum > 0) {
dispatch(
createNotificationThunk(