fix(cmake): add new required TERMINFO variable - #36
Draft
clason wants to merge 1 commit into
Draft
Conversation
Problem: #31 added a new TERMINFO variable that is checked at build time; this was added to the Makefile but not the CMake script (which Neovim uses). Solution: Define TERMINFO in CMakeLists.txt as well, copying the logic from the Makefile.
Member
|
I didn't forget it. The CMake support was already lacking in many ways. I started work on bringing that up to par overall. I can work on wrapping that up in the next few days. |
Member
Author
|
Well, but it wasn't broken (as in "Neovim fails to build now") ;) If you don't mind, I'll leave this PR up in the meantime for people who (somehow) noticed the version bump and wonder what's going on, but feel free to close it once you open yours. |
clason
marked this pull request as draft
August 24, 2026 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: #31 added a new TERMINFO variable that is checked at build
time; this was added to the Makefile but not the CMake script (which
Neovim uses).
Solution: Define TERMINFO in CMakeLists.txt as well, copying the logic
from the Makefile.