Correct Netscaler parser slug #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ko driver To align with the other slugs used for platforms I've corrected it to use netscaler instead of citrix_netscaler.
jdrew82
requested review from
itdependsnetworks,
jeffkala,
qduk and
abates
as code owners
|
This would require major version bump correct? As its a breaking change? Maybe we have to keep both for now and have a deprecation warning of sorts for the |
This could be considered a breaking change, yes. If we want to keep the original and just have two entries for the same platform I'm fine with that though I wonder how the tests would handle it. |
|
Think i'm good with this. I was researching for a decent way to do a deprecation warning on dictionary key, but doesn't seem there's a easy way. |
jeffkala
approved these changes
Aug 11, 2023
qduk
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to correct the slug used for Citrix Netscaler to align with netmiko driver that the other platforms use.
The tests have also been updated to match.