Fixed async event queue behaviour #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaitor
approved these changes
Jul 3, 2025
| const incomingMessage = params.message | ||
|
|
||
| async sendMessage(params: MessageSendParams): Promise<Message | Task> { | ||
| // const result = await super.sendMessage(params) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, sendMessage was delegated to default_request_handler, but we had some inconsistencies with async task management.
We have copied that functionality to
paymentRequestHandler.tsfile and now every event is processed accordingly.Besides, when the received a task-update event that finishes the task, now its metadata is copied to the
task.metadataattribute hence the user will be able to see the task cost breakdownIs this PR related with an open issue?
Related to Issue #
Types of changes
Checklist:
Funny gif