[nr-k8s-otel-collector] Adding NR Event Attribute identifier to event logs #1695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpattaswamy
previously approved these changes
Apr 29, 2025
|
let's also update the ReadMe to point to the new Otlp namespace https://github.com/newrelic/helm-charts/tree/master/charts/nr-k8s-otel-collector OtlpInfrastructureEvent |
Philip-R-Beckwith
added a commit
that referenced
this pull request
Jun 17, 2025
… logs #1695 (#1756) <!-- Thank you for contributing to New Relic's Helm charts. Before you submit this PR we'd like to make sure you are aware of our technical requirements: * https://github.com/newrelic-experimental/helm-charts/blob/master/CONTRIBUTING.md#technical-requirements For a quick overview across what we will look at reviewing your PR, please read our review guidelines: * https://github.com/newrelic-experimental/helm-charts/blob/master/REVIEW_GUIDELINES.md Following our best practices right from the start will accelerate the review process and help get your PR merged quicker. When updates to your PR are requested, please add new commits and do not squash the history. This will make it easier to identify new changes. The PR will be squashed anyways when it is merged. Thanks. For fast feedback, please @-mention maintainers that are listed in the Chart.yaml file. Please make sure you test your changes before you push them. Once pushed, a Github Action will run across your changes and do some initial checks and linting. These checks run very quickly. Please check the results. We would like these checks to pass before we even continue reviewing your changes. --> #### Is this a new chart No. #### What this PR does / why we need it: We're using this attribute to identify which logs are actually representative of events. And just like that we're already seeing infra events instead of logs. <img width="1667" alt="Screenshot 2025-04-29 at 1 51 32 PM" src="https://github.com/user-attachments/assets/b5e23070-907c-4d0b-b64b-aa64fdfbcb26" /> Also had to change more '|-' to '|' in the unit tests. My theory is that the unit tests aren't running unless a change that would impact them has been made. So then they do run and the |- makes them fail. Which is why I keep having to remove one or two - from unit tests every time I PR. #### Which issue this PR fixes *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)* - fixes # #### Special notes for your reviewer: #### Checklist [Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.] - [x] Chart Version bumped - [x] Variables are documented in the README.md - [x] Title of the PR starts with chart name (e.g. `[mychartname]`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No.
What this PR does / why we need it:
We're using this attribute to identify which logs are actually representative of events.
And just like that we're already seeing infra events instead of logs.
Also had to change more '|-' to '|' in the unit tests. My theory is that the unit tests aren't running unless a change that would impact them has been made. So then they do run and the |- makes them fail. Which is why I keep having to remove one or two - from unit tests every time I PR.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])