-
Notifications
You must be signed in to change notification settings - Fork 16
Nr 443280 early harvesting #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
458aa66 to
6de22e0
Compare
| #import "NRMAHarvestController.h" | ||
| #import "NewRelicInternalUtils.h" | ||
| #import "NRMAExceptionHandler.h" | ||
| static long long NR_DEFAULT_HARVEST_PERIOD = 60 * 1000; //milliseconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? Also it appears this was handled for the OldEventSystem but we'll also need to handle in the newer NRMAEventManager used by NewEventSystem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not do this yet in for the NewEventSystem. will do that now :)
cdillard-NewRelic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz address for NRMAEventManager additionally. thank you
6019ca6 to
8df719e
Compare
d3ea75b to
f616aa9
Compare
|
we won't be merging this until a later date when DEM approves. |
|
@cdillard-NewRelic Did the PR address your requested changes? Could we mark the change as resolved and just not approve the PR, as a failsafe, to prevent the PR from being merged before we are ready to do so. |
cdillard-NewRelic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but we'll wait to merge for a future release.
|
|
||
| - (void) setMaxEventBufferTime:(unsigned int)seconds { | ||
| [self.analyticsController setMaxEventBufferTime:seconds]; | ||
| [NRMATaskQueue queue:[[NRMAMetric alloc] initWithName:kNRSupportabilityPrefix@"/API/setMaxBufferTime" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing these metrics show up, you should change it to use the deferredMetrics like in the NRMASupportMetricHelper.m class.
+ (void) enqueueMaxEventBufferTimeMetric {
@synchronized (deferredMetrics) {
[deferredMetrics addObject:[[NRMAMetric alloc] initWithName:kNRSupportabilityPrefix@"/API/setMaxBufferTime"
value:@1
scope:nil]];
}
}
- Includes supportability tracking
8a81403 to
a6d8633
Compare
…buffer time and size
Jira ticket