Skip to content

Conversation

@cmcadams-newrelic
Copy link

@cmcadams-newrelic cmcadams-newrelic commented Dec 2, 2025

Jira ticket

  • Updates the default harvest event buffer time to 1 minute
  • New Includes supportability metrics for event buffer and pool size.
    • Logs custom metrics for default harvest time and/or default pool size.

@cmcadams-newrelic cmcadams-newrelic force-pushed the NR-443280-early-harvesting branch 2 times, most recently from 458aa66 to 6de22e0 Compare December 2, 2025 21:15
@cmcadams-newrelic cmcadams-newrelic changed the base branch from main to develop December 2, 2025 21:16
@cmcadams-newrelic cmcadams-newrelic requested review from cdillard-NewRelic and mbruin-NR and removed request for mbruin-NR December 2, 2025 21:16
#import "NRMAHarvestController.h"
#import "NewRelicInternalUtils.h"
#import "NRMAExceptionHandler.h"
static long long NR_DEFAULT_HARVEST_PERIOD = 60 * 1000; //milliseconds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? Also it appears this was handled for the OldEventSystem but we'll also need to handle in the newer NRMAEventManager used by NewEventSystem

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not do this yet in for the NewEventSystem. will do that now :)

Copy link
Member

@cdillard-NewRelic cdillard-NewRelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz address for NRMAEventManager additionally. thank you

@cmcadams-newrelic cmcadams-newrelic force-pushed the NR-443280-early-harvesting branch from 6019ca6 to 8df719e Compare December 3, 2025 16:52
@cmcadams-newrelic cmcadams-newrelic force-pushed the NR-443280-early-harvesting branch 2 times, most recently from d3ea75b to f616aa9 Compare December 5, 2025 17:34
@cdillard-NewRelic
Copy link
Member

we won't be merging this until a later date when DEM approves.

@Newrelic-Boomi
Copy link

@cmcadams-newrelic
Copy link
Author

@cdillard-NewRelic Did the PR address your requested changes? Could we mark the change as resolved and just not approve the PR, as a failsafe, to prevent the PR from being merged before we are ready to do so.

Copy link
Member

@cdillard-NewRelic cdillard-NewRelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but we'll wait to merge for a future release.


- (void) setMaxEventBufferTime:(unsigned int)seconds {
[self.analyticsController setMaxEventBufferTime:seconds];
[NRMATaskQueue queue:[[NRMAMetric alloc] initWithName:kNRSupportabilityPrefix@"/API/setMaxBufferTime"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing these metrics show up, you should change it to use the deferredMetrics like in the NRMASupportMetricHelper.m class.

+ (void) enqueueMaxEventBufferTimeMetric {
    @synchronized (deferredMetrics) {
        [deferredMetrics addObject:[[NRMAMetric alloc] initWithName:kNRSupportabilityPrefix@"/API/setMaxBufferTime"
                                                              value:@1
                                                              scope:nil]];
    }
}

@cmcadams-newrelic cmcadams-newrelic force-pushed the NR-443280-early-harvesting branch from 8a81403 to a6d8633 Compare December 22, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants