feature: NR-455916 errored session sample #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sessions sampling is added
…to feature/NR-455916-error-session-sample
… feature/NR-455916-error-session-sample # Conflicts: # Agent/General/NewRelicAgentInternal.h # Agent/General/NewRelicAgentInternal.m # Agent/SessionReplay/SessionReplayManager.swift
… feature/NR-455916-error-session-sample
… feature/NR-455916-error-session-sample # Conflicts: # Agent/SessionReplay/ViewCaptors/UIImageViewThingy.swift
mbruin-NR
reviewed
Dec 18, 2025
| } | ||
|
|
||
| /// Checks if a full snapshot should be forced (every 15 seconds) | ||
| private func checkAndForceFullSnapshot(for frame: SessionReplayFrame) { |
Contributor
There was a problem hiding this comment.
checkAndForceFullSnapshot:
- This is running even while in full mode when it shouldn't be.
- It should only apply to the persisted frames because in memory frames are processed at harvest time.
- I think it needs rethought because the first frame needs to be a full frame not just every 15.
- Maybe doing this and keeping 30 frames but deleting in batches of 15 might work.
- Or coping in some of my changes for chunking that allows for the raw frames to be persisted instead of the processed frames. If we do it this way this logic shouldn't be needed at all. Just process the frames at harvest time.
Member
Author
There was a problem hiding this comment.
change to only run in error mode. I've change this to use the sliding window. changed to only use persisted frames.
mbruin-NR
reviewed
Dec 18, 2025
| // Process buffered frames to file for persistence | ||
| DispatchQueue.global(qos: .background).async { [weak self] in | ||
| guard let self = self else { return } | ||
| self.processFrameToFile(bufferedFrame.frame) |
Contributor
There was a problem hiding this comment.
Aren't these frames already being persisted to file while they're captured?
Member
Author
There was a problem hiding this comment.
Yeah but this is capturing them to a seperate error buffer. It seems to work. 🤷
Member
Author
There was a problem hiding this comment.
Removed this part. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by various error types: Handled Exception and LogError and recordError only currently.
When transitioning from error mode to full mode full session replay is enabled.
Full Snapshot Capture:
Session replay is now configured to capture a full snapshot every 15 seconds, ensuring that each replay commences with a comprehensive snapshot.