Skip to content

feat(alerts): add validation for evaluation_delay in NRQL alert con… #2870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kyo2bay
Copy link

@kyo2bay kyo2bay commented Apr 29, 2025

Description

Added validation for evaluation delay of NRQL alert condition

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Step 1
  • Step 2
  • etc

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kyo2bay kyo2bay force-pushed the refactor_validation_evlauation_delay branch from 30653dc to 707f35f Compare April 29, 2025 14:38
@kyo2bay kyo2bay changed the title feat(newrelic): add validation for evaluation_delay in NRQL alert con… feat(alert): add validation for evaluation_delay in NRQL alert con… Apr 29, 2025
@kyo2bay kyo2bay changed the title feat(alert): add validation for evaluation_delay in NRQL alert con… feat(alerts): add validation for evaluation_delay in NRQL alert con… Apr 29, 2025
@kyo2bay kyo2bay force-pushed the refactor_validation_evlauation_delay branch from 707f35f to 445f965 Compare April 29, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants