Skip to content

feat(synthetics): set runtime_type and runtime_type_version as required #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Aashirwadjain
Copy link
Contributor

Description

This PR aims to set runtime_type and runtime_type_version schema attributes as required for synthetic monitors.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2025

Codecov Report

Attention: Patch coverage is 21.05263% with 30 lines in your changes missing coverage. Please review.

Project coverage is 31.78%. Comparing base (88b0a27) to head (084fb41).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ures_newrelic_synthetics_simple_browser_monitor.go 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2881      +/-   ##
==========================================
+ Coverage   30.55%   31.78%   +1.23%     
==========================================
  Files         104      104              
  Lines       28689    28661      -28     
==========================================
+ Hits         8765     9110     +345     
+ Misses      19748    19337     -411     
- Partials      176      214      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

❌ Invalid Conventional Commits Detected

The following commits do not follow the Conventional Commits format:

97a8610 - feat(synthetics_monitor): add default values to runtime_type and runtime_type_version

Please update these commit messages to follow the format:
<type>[optional scope]: <description>

Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test

Copy link

❌ Invalid Conventional Commits Detected

The following commits do not follow the Conventional Commits format:

97a8610 - feat(synthetics_monitor): add default values to runtime_type and runtime_type_version

Please update these commit messages to follow the format:
<type>[optional scope]: <description>

Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test

Copy link

❌ Invalid Conventional Commits Detected

The following commits do not follow the Conventional Commits format:

97a8610 - feat(synthetics_monitor): add default values to runtime_type and runtime_type_version

Please update these commit messages to follow the format:
<type>[optional scope]: <description>

Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants