Drop core-js and move to vite
#563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
¹: `core-js` is now automatically loaded by Nextcloud server so no need for bundling Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
ShGKme
approved these changes
Jan 24, 2024
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
I haven't checked what we do in other libs, but this migration brings one change - dist is now minimized.
I'm not sure it is needed because:
- The final build of app/library is handled by their bundling anyway, minimizing library dist doesn't have any advantages
- It makes debug of apps/libs more complicated, because even in dev build of app/lib, this dependency is minimized
Other than that, everything is fine
ShGKme
reviewed
Jan 24, 2024
Contributor
Author
We do it everywhere as well. Maybe adjust at |
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
enh/drop-corejs-move-vite
branch
from
abe8285 to
f1df73b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core-jsas a dependency, it is automatically included and loaded by server core.