refactor(Makefile): Cleanup variables #1367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
joshtrichards
force-pushed
the
refactor/makefile/cleanup
branch
from
a4ee081 to
17ca5ee
Compare
Signed-off-by: Josh <[email protected]>
joshtrichards
approved these changes
Jun 9, 2024
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Made one small additional adjustment that was needed. Passes all tests now.
Member
Author
|
Maybe @bigcat88 you can review this as well? |
Member
Thank you again
Looks good, let's merge this |
bigcat88
approved these changes
Jun 10, 2024
bigcat88
requested changes
Jun 10, 2024
| coverage=$(poetry_run) coverage | ||
| manage-script=$(CURDIR)/manage.py | ||
| manage=$(poetry_run) $(manage-script) | ||
| db=sqlite |
Member
There was a problem hiding this comment.
please return "$db" variable, it is used in tests. except these all other changes are good
Signed-off-by: Alexander Piskun <[email protected]>
bigcat88
approved these changes
Jun 10, 2024
Member
bigcat88
left a comment
bigcat88
left a comment
There was a problem hiding this comment.
now the tests for pgsql is run on pgsql and not on sqlite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to understand the Makefile with all these unnecessary variables is really hard, so I just removed them and moved almost everything inline.