Skip to content

Conversation

@ChristophWurst
Copy link
Member

Mixing two IDs makes reading logs more complex than necessary. Let's be consistent.

@ChristophWurst
Copy link
Member Author

/backport to stable6.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Oct 8, 2025
@ChristophWurst
Copy link
Member Author

/backport to stable5.5

@ChristophWurst
Copy link
Member Author

/backport to stable4.7

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.33%. Comparing base (a3846f9) to head (47084f0).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/services/appointmentService.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7537      +/-   ##
==========================================
- Coverage   13.34%   13.33%   -0.02%     
==========================================
  Files         218      218              
  Lines       11350    11360      +10     
  Branches     2725     2714      -11     
==========================================
  Hits         1515     1515              
- Misses       9475     9485      +10     
  Partials      360      360              
Flag Coverage Δ
javascript 13.33% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChristophWurst
Copy link
Member Author

CI fix at #7532

@st3iny st3iny force-pushed the fix/appointments/unify-ids branch from 354aa02 to a95cad5 Compare October 8, 2025 08:19
@st3iny st3iny enabled auto-merge October 8, 2025 08:19
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 8, 2025
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Oct 8, 2025
@ChristophWurst ChristophWurst marked this pull request as draft October 8, 2025 09:01
auto-merge was automatically disabled October 8, 2025 09:01

Pull request was converted to draft

@ChristophWurst
Copy link
Member Author

Tests are not passing

@ChristophWurst ChristophWurst force-pushed the fix/appointments/unify-ids branch from a95cad5 to 645bc94 Compare October 8, 2025 09:40
Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst force-pushed the fix/appointments/unify-ids branch from 645bc94 to 47084f0 Compare October 8, 2025 14:47
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 8, 2025
@ChristophWurst ChristophWurst marked this pull request as ready for review October 8, 2025 14:47
@ChristophWurst ChristophWurst merged commit f41650c into main Oct 8, 2025
39 of 42 checks passed
@ChristophWurst ChristophWurst deleted the fix/appointments/unify-ids branch October 8, 2025 14:51
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Oct 8, 2025
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

3 participants