Skip to content

perf(appointments): reduce bundle size bloat by @nextcloud/vue #7671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChristophWurst wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(appointments): reduce bundle size bloat by @nextcloud/vue #7671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Appointments/AppointmentBookingConfirmation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</template>

<script>
import { NcEmptyContent as EmptyContent } from '@nextcloud/vue'
import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
Copy link
Member

@tcitworld tcitworld Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used as EmptyContent, not NcEmptyContent

import EmailIcon from 'vue-material-design-icons/EmailOutline.vue'
export default {
Expand Down
10 changes: 4 additions & 6 deletions src/components/Appointments/AppointmentDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
{{ $t('calendar', 'Your email address') }}
</div>
<input
ref="email"

Check warning on line 55 in src/components/Appointments/AppointmentDetails.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'email' is defined as ref, but never used
v-model="email"
type="email"
autocapitalize="none"
Expand Down Expand Up @@ -104,12 +104,10 @@
</template>

<script>
import {
NcAvatar as Avatar,
NcButton,
NcLoadingIcon,
NcNoteCard,
} from '@nextcloud/vue'
import Avatar from '@nextcloud/vue/components/NcAvatar'
import NcButton from '@nextcloud/vue/components/NcButton'
import NcLoadingIcon from '@nextcloud/vue/components/NcLoadingIcon'
import NcNoteCard from '@nextcloud/vue/components/NcNoteCard'
import IconBack from 'vue-material-design-icons/ArrowLeft.vue'
import IconCalendar from 'vue-material-design-icons/CalendarOutline.vue'
import IconCheck from 'vue-material-design-icons/CheckOutline.vue'
Expand Down
2 changes: 1 addition & 1 deletion src/components/Appointments/AppointmentSlot.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</template>

<script>
import { NcButton } from '@nextcloud/vue'
import NcButton from '@nextcloud/vue/components/NcButton'
import { timeStampToLocaleTime } from '../../utils/localeTime.js'

export default {
Expand Down
13 changes: 6 additions & 7 deletions src/views/Appointments/Booking.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,12 @@

<script>
import { showError } from '@nextcloud/dialogs'
import {
NcAvatar as Avatar,
NcDateTimePicker as DateTimePicker,
NcEmptyContent,
NcGuestContent,
NcTimezonePicker as TimezonePicker,
} from '@nextcloud/vue'
import NcButton from '@nextcloud/vue/components/NcButton'
import Avatar from '@nextcloud/vue/components/NcAvatar'

Check failure on line 88 in src/views/Appointments/Booking.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Expected "@nextcloud/vue/components/NcAvatar" to come before "@nextcloud/vue/components/NcButton"
import DateTimePicker from '@nextcloud/vue/components/NcDateTimePicker'
import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
import NcGuestContent from '@nextcloud/vue/components/NcGuestContent'
import TimezonePicker from '@nextcloud/vue/components/NcDateTimePicker'

Check failure on line 92 in src/views/Appointments/Booking.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Expected "@nextcloud/vue/components/NcDateTimePicker" to come before "@nextcloud/vue/components/NcGuestContent"
import MDILoading from 'vue-material-design-icons/Loading.vue'
import AppointmentBookingConfirmation from '../../components/Appointments/AppointmentBookingConfirmation.vue'
import AppointmentDetails from '../../components/Appointments/AppointmentDetails.vue'
Expand Down
Loading