-
Notifications
You must be signed in to change notification settings - Fork 198
feat!: migrate app to Vue 3 #4581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4581 +/- ##
============================================
+ Coverage 9.86% 65.62% +55.76%
Complexity 265 265
============================================
Files 124 26 -98
Lines 6173 771 -5402
Branches 1423 0 -1423
============================================
- Hits 609 506 -103
+ Misses 5441 265 -5176
+ Partials 123 0 -123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested.
- Created new contact
- Updated existing contact
- Removed contact
- Added properties
- Removed properties
- Added picture
- Removed picture
- Tested drop downs
- Tested text fields
- Tested date fields
- Tested multi select and action
All seems to be functioning as expected
SebastianKrupinski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke too soon, this breaks contacts merging, check boxes and radio selectors on the merge screen are not working.
Right, I forgot to check the new features after the rebase. Will have a look tomorrow. EDIT: Done |
SebastianKrupinski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again.
The contacts merging is now working properly and all other functions seem good too.
|
Since this is a major overhaul and does not support anything before Nc32, maybe we should do a major version bump? version 8? |
|
@SebastianKrupinski Yeah, I'd also vote for a major bump especially regarding the (coming) design changes in nc-vue v9. I'll talk about it in our next team call. |
Signed-off-by: Richard Steinmetz <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
Resolves #4298
Also drops compatibility with Nextcloud < 32 due to major design changes in the latest version of
@nextcloud/vuewhich will only be compatible with Nextcloud 32.Dropped dependencies
vuex-router-sync=> Not required anymore and not compatible with Vuex 4.vue-click-outside=> Not required anymore. This is now handled by@nextcloud/vuedirectly.Replaced dependencies
vue-virtual-scroll-list,vue-virtual-scroller=>virtuaAll other dependencies requiring Vue had more recent version available which are compatible with Vue 3.
TODO
npm run lint:fix)@nextcloud/vue9 breaking changes (manually) -> https://github.com/nextcloud-libraries/nextcloud-vue/blob/main/CHANGELOG.mdical.jsand Vue 3 reactivity (proxies) -> useshallowRef()