Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Jul 24, 2025

Resolves #4298

Also drops compatibility with Nextcloud < 32 due to major design changes in the latest version of @nextcloud/vue which will only be compatible with Nextcloud 32.

Dropped dependencies

  • vuex-router-sync => Not required anymore and not compatible with Vuex 4.
  • vue-click-outside => Not required anymore. This is now handled by @nextcloud/vue directly.

Replaced dependencies

  • vue-virtual-scroll-list, vue-virtual-scroller => virtua

All other dependencies requiring Vue had more recent version available which are compatible with Vue 3.

TODO

@st3iny st3iny self-assigned this Jul 24, 2025
@st3iny st3iny added enhancement New feature or request 2. developing Work in progress technical debt labels Jul 24, 2025
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.62%. Comparing base (f67a9b5) to head (475327d).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##              main    #4581       +/-   ##
============================================
+ Coverage     9.86%   65.62%   +55.76%     
  Complexity     265      265               
============================================
  Files          124       26       -98     
  Lines         6173      771     -5402     
  Branches      1423        0     -1423     
============================================
- Hits           609      506      -103     
+ Misses        5441      265     -5176     
+ Partials       123        0      -123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SebastianKrupinski

This comment was marked as resolved.

@st3iny st3iny marked this pull request as ready for review August 20, 2025 13:50
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 20, 2025
@st3iny st3iny changed the title feat: migrate app to Vue 3 feat!: migrate app to Vue 3 Aug 20, 2025
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

  • Created new contact
  • Updated existing contact
  • Removed contact
  • Added properties
  • Removed properties
  • Added picture
  • Removed picture
  • Tested drop downs
  • Tested text fields
  • Tested date fields
  • Tested multi select and action

All seems to be functioning as expected

Copy link
Contributor

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke too soon, this breaks contacts merging, check boxes and radio selectors on the merge screen are not working.

@st3iny
Copy link
Member Author

st3iny commented Aug 20, 2025

Spoke too soon, this breaks contacts merging, check boxes and radio selectors on the merge screen are not working.

Right, I forgot to check the new features after the rebase. Will have a look tomorrow.

EDIT: Done

Copy link
Contributor

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again.

The contacts merging is now working properly and all other functions seem good too.

@SebastianKrupinski
Copy link
Contributor

@st3iny

Since this is a major overhaul and does not support anything before Nc32, maybe we should do a major version bump? version 8?

@st3iny
Copy link
Member Author

st3iny commented Aug 22, 2025

@SebastianKrupinski Yeah, I'd also vote for a major bump especially regarding the (coming) design changes in nc-vue v9.

I'll talk about it in our next team call.

st3iny added 2 commits August 22, 2025 09:39
Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny merged commit 6b3c28e into main Aug 22, 2025
35 checks passed
@st3iny st3iny deleted the feat/vue3 branch August 22, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to Vue 3

3 participants