Skip to content

[stable31] fix: Check owner can create boards when importing #7343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luka-nextcloud merged 2 commits into from
Nov 6, 2025
Merged

[stable31] fix: Check owner can create boards when importing #7343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c87588
fix: check creation permission when import board
luka-nextcloud Nov 4, 2025
e37d2ab
fix: remove redundant file change
luka-nextcloud Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/Controller/BoardImportApiController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@

namespace OCA\Deck\Controller;

use OCA\Deck\NoPermissionException;
use OCA\Deck\Service\Importer\BoardImportService;
use OCA\Deck\Service\PermissionService;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataResponse;
use OCP\AppFramework\OCSController;
Expand All @@ -18,6 +20,7 @@ public function __construct(
string $appName,
IRequest $request,
private BoardImportService $boardImportService,
private PermissionService $permissionService,
private string $userId,
) {
parent::__construct($appName, $request);
Expand All @@ -29,6 +32,9 @@ public function __construct(
* @NoCSRFRequired
*/
public function import(string $system, array $config, array $data): DataResponse {
if (!$this->permissionService->canCreate()) {
throw new NoPermissionException('Creating boards has been disabled for your account.');
}
$this->boardImportService->setSystem($system);
$config = json_decode(json_encode($config));
$config->owner = $this->userId;
Expand Down
23 changes: 23 additions & 0 deletions tests/unit/controller/BoardImportApiControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

use OCA\Deck\Db\Board;
use OCA\Deck\Service\Importer\BoardImportService;
use OCA\Deck\Service\PermissionService;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataResponse;
use OCP\IRequest;
Expand All @@ -37,16 +38,20 @@ class BoardImportApiControllerTest extends \Test\TestCase {
private $controller;
/** @var BoardImportService|MockObject */
private $boardImportService;
/** @var PermissionService|MockObject */
private $permissionService;

public function setUp(): void {
parent::setUp();
$this->request = $this->createMock(IRequest::class);
$this->boardImportService = $this->createMock(BoardImportService::class);
$this->permissionService = $this->createMock(PermissionService::class);

$this->controller = new BoardImportApiController(
$this->appName,
$this->request,
$this->boardImportService,
$this->permissionService,
$this->userId
);
}
Expand Down Expand Up @@ -75,9 +80,27 @@ public function testImport() {
$data = [
'name' => 'test'
];
$this->permissionService
->method('canCreate')
->willReturn(true);
$actual = $this->controller->import($system, $config, $data);
$board = $this->createMock(Board::class);
$this->assertInstanceOf(Board::class, $board);
$this->assertEquals(HTTP::STATUS_OK, $actual->getStatus());
}

public function testImportWithoutPermission() {
$system = 'trelloJson';
$config = [
'owner' => 'test'
];
$data = [
'name' => 'test'
];
$this->permissionService
->method('canCreate')
->willReturn(false);
$this->expectException(\OCA\Deck\NoPermissionException::class);
$this->controller->import($system, $config, $data);
}
}
Loading